Class: Brakeman::CheckCreateWith

Inherits:
BaseCheck show all
Defined in:
lib/brakeman/checks/check_create_with.rb

Constant Summary

Constants inherited from BaseCheck

BaseCheck::CONFIDENCE

Constants included from Util

Util::ALL_PARAMETERS, Util::COOKIES, Util::COOKIES_SEXP, Util::PARAMETERS, Util::PARAMS_SEXP, Util::PATH_PARAMETERS, Util::QUERY_PARAMETERS, Util::REQUEST_ENV, Util::REQUEST_PARAMETERS, Util::REQUEST_PARAMS, Util::SESSION, Util::SESSION_SEXP

Constants inherited from SexpProcessor

SexpProcessor::VERSION

Instance Attribute Summary

Attributes inherited from BaseCheck

#tracker, #warnings

Attributes inherited from SexpProcessor

#context, #env, #expected

Instance Method Summary collapse

Methods inherited from BaseCheck

#add_result, inherited, #initialize, #process_call, #process_cookies, #process_default, #process_if, #process_params, #process_string_interp

Methods included from Util

#array?, #block?, #call?, #camelize, #contains_class?, #context_for, #cookies?, #false?, #file_by_name, #file_for, #github_url, #hash?, #hash_access, #hash_insert, #hash_iterate, #integer?, #make_call, #node_type?, #number?, #params?, #pluralize, #regexp?, #relative_path, #request_env?, #request_value?, #result?, #set_env_defaults, #sexp?, #string?, #symbol?, #table_to_csv, #template_path_to_name, #true?, #truncate_table, #underscore

Methods included from ProcessorHelper

#class_name, #process_all, #process_all!, #process_call_args, #process_class, #process_module

Methods inherited from SexpProcessor

#error_handler, #in_context, #initialize, #process, #process_dummy, #scope

Constructor Details

This class inherits a constructor from Brakeman::BaseCheck

Instance Method Details

#danger_level(exp) ⇒ Object

For a given create_with call, set confidence level. Ignore calls that use permit()


49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
# File 'lib/brakeman/checks/check_create_with.rb', line 49

def danger_level exp
  return unless sexp? exp

  if call? exp and exp.method == :permit
    nil
  elsif request_value? exp
    CONFIDENCE[:high]
  elsif hash? exp
    nil
  elsif has_immediate_user_input?(exp)
    CONFIDENCE[:high]
  elsif include_user_input? exp
    CONFIDENCE[:med]
  else
    CONFIDENCE[:low]
  end
end

#generic_warningObject


67
68
69
70
71
72
73
74
# File 'lib/brakeman/checks/check_create_with.rb', line 67

def generic_warning
    warn :warning_type => "Mass Assignment",
      :warning_code => :CVE_2014_3514,
      :message => @message,
      :gem_info => gemfile_or_environment,
      :confidence => CONFIDENCE[:med],
      :link_path => "https://groups.google.com/d/msg/rubyonrails-security/M4chq5Sb540/CC1Fh0Y_NWwJ"
end

#process_result(result) ⇒ Object


28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
# File 'lib/brakeman/checks/check_create_with.rb', line 28

def process_result result
  return if duplicate? result
  add_result result
  arg = result[:call].first_arg

  confidence = danger_level arg

  if confidence
    @warned = true

    warn :warning_type => "Mass Assignment",
      :warning_code => :CVE_2014_3514_call,
      :result => result,
      :message => @message,
      :confidence => confidence,
      :link_path => "https://groups.google.com/d/msg/rubyonrails-security/M4chq5Sb540/CC1Fh0Y_NWwJ"
  end
end

#run_checkObject


8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
# File 'lib/brakeman/checks/check_create_with.rb', line 8

def run_check
  @warned = false

  if version_between? "4.0.0", "4.0.8"
    suggested_version = "4.0.9"
  elsif version_between? "4.1.0", "4.1.4"
    suggested_version = "4.1.5"
  else
    return
  end

  @message = "create_with is vulnerable to strong params bypass. Upgrade to Rails #{suggested_version} or patch"

  tracker.find_call(:method => :create_with, :nested => true).each do |result|
    process_result result
  end

  generic_warning unless @warned
end