Class: Brakeman::CheckSelectVulnerability

Inherits:
BaseCheck show all
Defined in:
lib/brakeman/checks/check_select_vulnerability.rb

Overview

Checks for select() helper vulnerability in some versions of Rails 3 groups.google.com/group/rubyonrails-security/browse_thread/thread/9da0c515a6c4664

Constant Summary

Constants inherited from BaseCheck

BaseCheck::CONFIDENCE

Constants included from Util

Util::ALL_PARAMETERS, Util::COOKIES, Util::PARAMETERS, Util::PATH_PARAMETERS, Util::QUERY_PARAMETERS, Util::REQUEST_ENV, Util::REQUEST_PARAMETERS, Util::REQUEST_PARAMS, Util::SESSION

Constants inherited from SexpProcessor

SexpProcessor::VERSION

Instance Attribute Summary

Attributes inherited from BaseCheck

#tracker, #warnings

Attributes inherited from SexpProcessor

#context, #env, #expected

Instance Method Summary collapse

Methods inherited from BaseCheck

#add_result, #initialize, #process_call, #process_cookies, #process_default, #process_if, #process_params

Methods included from Util

#array?, #call?, #camelize, #contains_class?, #context_for, #cookies?, #false?, #file_by_name, #file_for, #hash?, #hash_access, #hash_insert, #hash_iterate, #integer?, #node_type?, #number?, #params?, #pluralize, #regexp?, #request_env?, #request_value?, #result?, #set_env_defaults, #sexp?, #string?, #symbol?, #table_to_csv, #true?, #truncate_table, #underscore

Methods included from ProcessorHelper

#class_name, #process_all, #process_module

Methods inherited from SexpProcessor

#error_handler, #in_context, #initialize, #process, #process_dummy, #scope

Constructor Details

This class inherits a constructor from Brakeman::BaseCheck

Instance Method Details

#process_result(result) ⇒ Object 



35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
 
# File 'lib/brakeman/checks/check_select_vulnerability.rb', line 35

def process_result result
  return if duplicate? result

  third_arg = result[:call].args[2]

  #Check for user input in options parameter
  if sexp? third_arg and include_user_input? third_arg
    add_result result

    if node_type? third_arg, :string_interp, :dstr
      confidence = CONFIDENCE[:med]
    else
      confidence = CONFIDENCE[:low]
    end

    warn :template => result[:location][1],
        :warning_type => "Cross Site Scripting",
        :result => result,
        :message => @message,
        :confidence => confidence
  end
end

#run_check ⇒ Object 



10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
 
# File 'lib/brakeman/checks/check_select_vulnerability.rb', line 10

def run_check

  if version_between? "3.0.0", "3.0.11"
    suggested_version = "3.0.12"
  elsif version_between? "3.1.0", "3.1.3"
    suggested_version = "3.1.4"
  elsif version_between? "3.2.0", "3.2.1"
    suggested_version = "3.2.2"
  elsif version_between? "2.0.0", "2.3.14"
    suggested_version = "3 or use options_for_select"
  else
    return
  end

  @message = "Upgrade to Rails #{suggested_version}, #{tracker.config[:rails_version]} select() helper is vulnerable"

  calls = tracker.find_call(:target => nil, :method => :select).select do |result|
    result[:location][0] == :template
  end

  calls.each do |result|
    process_result result
  end
end