Class: Brakeman::CheckSkipBeforeFilter

Inherits:
BaseCheck show all
Defined in:
lib/brakeman/checks/check_skip_before_filter.rb

Overview

At the moment, this looks for

skip_before_filter :verify_authenticity_token, :except => [...]

which is essentially a blacklist approach (no actions are checked EXCEPT the ones listed) versus a whitelist approach (ONLY the actions listed will skip the check)

Constant Summary

Constants inherited from BaseCheck

BaseCheck::CONFIDENCE

Constants included from Util

Util::ALL_PARAMETERS, Util::COOKIES, Util::PARAMETERS, Util::PATH_PARAMETERS, Util::QUERY_PARAMETERS, Util::REQUEST_ENV, Util::REQUEST_PARAMETERS, Util::REQUEST_PARAMS, Util::SESSION

Constants inherited from SexpProcessor

SexpProcessor::VERSION

Instance Attribute Summary

Attributes inherited from BaseCheck

#tracker, #warnings

Attributes inherited from SexpProcessor

#context, #env, #expected

Instance Method Summary collapse

Methods inherited from BaseCheck

#add_result, #initialize, #process_call, #process_cookies, #process_default, #process_if, #process_params

Methods included from Util

#array?, #call?, #camelize, #contains_class?, #context_for, #cookies?, #false?, #file_by_name, #file_for, #hash?, #hash_access, #hash_insert, #hash_iterate, #integer?, #node_type?, #number?, #params?, #pluralize, #regexp?, #request_env?, #request_value?, #result?, #set_env_defaults, #sexp?, #string?, #symbol?, #table_to_csv, #true?, #truncate_table, #underscore

Methods included from ProcessorHelper

#class_name, #process_all, #process_module

Methods inherited from SexpProcessor

#error_handler, #in_context, #initialize, #process, #process_dummy, #scope

Constructor Details

This class inherits a constructor from Brakeman::BaseCheck

Instance Method Details

#process_skip_filter(filter, controller) ⇒ Object 



25
26
27
28
29
30
31
32
33
 
# File 'lib/brakeman/checks/check_skip_before_filter.rb', line 25

def process_skip_filter filter, controller
  if skip_verify_except? filter
    warn :class => controller[:name],
      :warning_type => "Cross-Site Request Forgery",
      :message => "Use whitelist (:only => [..]) when skipping CSRF check",
      :code => filter,
      :confidence => CONFIDENCE[:med]
  end
end

#run_check ⇒ Object 



15
16
17
18
19
20
21
22
23
 
# File 'lib/brakeman/checks/check_skip_before_filter.rb', line 15

def run_check
  tracker.controllers.each do |name, controller|
    if filter_skips = (controller[:options][:skip_before_filter] or controller[:options][:skip_filter])
      filter_skips.each do |filter|
        process_skip_filter filter, controller
      end
    end
  end
end

#skip_verify_except?(filter) ⇒ Boolean

Returns:

  • (Boolean) 


35
36
37
38
39
40
41
42
43
44
45
46
47
 
# File 'lib/brakeman/checks/check_skip_before_filter.rb', line 35

def skip_verify_except? filter
  return false unless call? filter

  args = filter.args

  if symbol? args.first and args.first.value == :verify_authenticity_token and hash? args.last
    if hash_access(args.last, :except)
      return true
    end
  end

  false
end