Class: Brakeman::CheckStripTags

Inherits:
BaseCheck show all
Defined in:
lib/brakeman/checks/check_strip_tags.rb

Overview

Check for uses of strip_tags in Rails versions before 3.0.17, 3.1.8, 3.2.8 (including 2.3.x): groups.google.com/d/topic/rubyonrails-security/FgVEtBajcTY/discussion

Check for uses of strip_tags in Rails versions before 2.3.13 and 3.0.10: groups.google.com/group/rubyonrails-security/browse_thread/thread/2b9130749b74ea12

Constant Summary

Constants inherited from BaseCheck

BaseCheck::CONFIDENCE

Constants included from Util

Util::ALL_PARAMETERS, Util::COOKIES, Util::PARAMETERS, Util::PATH_PARAMETERS, Util::QUERY_PARAMETERS, Util::REQUEST_ENV, Util::REQUEST_PARAMETERS, Util::REQUEST_PARAMS, Util::SESSION

Constants inherited from SexpProcessor

SexpProcessor::VERSION

Instance Attribute Summary

Attributes inherited from BaseCheck

#tracker, #warnings

Attributes inherited from SexpProcessor

#context, #env, #expected

Instance Method Summary collapse

Methods inherited from BaseCheck

#add_result, #initialize, #process_call, #process_cookies, #process_default, #process_if, #process_params

Methods included from Util

#array?, #call?, #camelize, #contains_class?, #context_for, #cookies?, #false?, #file_by_name, #file_for, #hash?, #hash_access, #hash_insert, #hash_iterate, #integer?, #node_type?, #number?, #params?, #pluralize, #regexp?, #request_env?, #request_value?, #result?, #set_env_defaults, #sexp?, #string?, #symbol?, #table_to_csv, #true?, #truncate_table, #underscore

Methods included from ProcessorHelper

#class_name, #process_all, #process_module

Methods inherited from SexpProcessor

#error_handler, #in_context, #initialize, #process, #process_dummy, #scope

Constructor Details

This class inherits a constructor from Brakeman::BaseCheck

Instance Method Details

#cve_2011_2931 ⇒ Object 



20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
 
# File 'lib/brakeman/checks/check_strip_tags.rb', line 20

def cve_2011_2931
  if version_between?('2.0.0', '2.3.12') or version_between?('3.0.0', '3.0.9')
    if tracker.config[:rails_version] =~ /^3/
      message = "Versions before 3.0.10 have a vulnerability in strip_tags (CVE-2011-2931)"
    else
      message = "Versions before 2.3.13 have a vulnerability in strip_tags (CVE-2011-2931)"
    end

    warn :warning_type => "Cross Site Scripting",
      :message => message,
      :file => gemfile_or_environment,
      :confidence => CONFIDENCE[:high],
      :link_path => "https://groups.google.com/d/topic/rubyonrails-security/K5EwdJt06hI/discussion"
  end
end

#cve_2012_3465 ⇒ Object 



36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
 
# File 'lib/brakeman/checks/check_strip_tags.rb', line 36

def cve_2012_3465
  case
  when (version_between?('2.0.0', '2.3.14') and tracker.config[:escape_html])
    message = "All Rails 2.x versions have a vulnerability in strip_tags (CVE-2012-3465)"
  when version_between?('3.0.10', '3.0.16')
    message = "Rails #{tracker.config[:rails_version]} has a vulnerability in strip_tags (CVE-2012-3465). Upgrade to 3.0.17"
  when version_between?('3.1.0', '3.1.7')
    message = "Rails #{tracker.config[:rails_version]} has a vulnerability in strip_tags (CVE-2012-3465). Upgrade to 3.1.8"
  when version_between?('3.2.0', '3.2.7')
    message = "Rails #{tracker.config[:rails_version]} has a vulnerability in strip_tags (CVE-2012-3465). Upgrade to 3.2.8"
  else
    return
  end

  warn :warning_type => "Cross Site Scripting",
    :message => message,
    :confidence => CONFIDENCE[:high],
    :file => gemfile_or_environment,
    :link_path => "https://groups.google.com/d/topic/rubyonrails-security/FgVEtBajcTY/discussion"
end

#run_check ⇒ Object 



13
14
15
16
17
18
 
# File 'lib/brakeman/checks/check_strip_tags.rb', line 13

def run_check
  if uses_strip_tags?
    cve_2011_2931
    cve_2012_3465
  end
end

#uses_strip_tags? ⇒ Boolean

Returns:

  • (Boolean) 


57
58
59
60
61
 
# File 'lib/brakeman/checks/check_strip_tags.rb', line 57

def uses_strip_tags?
  Brakeman.debug "Finding calls to strip_tags()"

  not tracker.find_call(:target => false, :method => :strip_tags).empty?
end