Class: Brakeman::CheckWithoutProtection

Inherits:
BaseCheck show all
Defined in:
lib/brakeman/checks/check_without_protection.rb

Overview

Check for bypassing mass assignment protection with without_protection => true

Only for Rails 3.1

Constant Summary

Constants inherited from BaseCheck

BaseCheck::CONFIDENCE

Constants included from Util

Util::ALL_PARAMETERS, Util::COOKIES, Util::PARAMETERS, Util::PATH_PARAMETERS, Util::QUERY_PARAMETERS, Util::REQUEST_ENV, Util::REQUEST_PARAMETERS, Util::REQUEST_PARAMS, Util::SESSION

Constants inherited from SexpProcessor

SexpProcessor::VERSION

Instance Attribute Summary

Attributes inherited from BaseCheck

#tracker, #warnings

Attributes inherited from SexpProcessor

#context, #env, #expected

Instance Method Summary collapse

Methods inherited from BaseCheck

#add_result, #initialize, #process_call, #process_cookies, #process_default, #process_if, #process_params

Methods included from Util

#array?, #call?, #camelize, #contains_class?, #context_for, #cookies?, #false?, #file_by_name, #file_for, #hash?, #hash_access, #hash_insert, #hash_iterate, #integer?, #node_type?, #number?, #params?, #pluralize, #regexp?, #request_env?, #request_value?, #result?, #set_env_defaults, #sexp?, #string?, #symbol?, #table_to_csv, #true?, #truncate_table, #underscore

Methods included from ProcessorHelper

#class_name, #process_all, #process_module

Methods inherited from SexpProcessor

#error_handler, #in_context, #initialize, #process, #process_dummy, #scope

Constructor Details

This class inherits a constructor from Brakeman::BaseCheck

Instance Method Details

#process_result(res) ⇒ Object

All results should be Model.new(…) or Model.attributes=() calls



34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
 
# File 'lib/brakeman/checks/check_without_protection.rb', line 34

def process_result res
  call = res[:call]
  last_arg = call.args.last

  if hash? last_arg and not call.original_line and not duplicate? res

    if value = hash_access(last_arg, :without_protection)
      if true? value
        add_result res

        if input = include_user_input?(call.arglist)
          confidence = CONFIDENCE[:high]
          user_input = input.match
        else
          confidence = CONFIDENCE[:med]
          user_input = nil
        end

        warn :result => res, 
          :warning_type => "Mass Assignment", 
          :message => "Unprotected mass assignment",
          :code => call, 
          :user_input => user_input,
          :confidence => confidence

      end
    end
  end
end

#run_check ⇒ Object 



12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
 
# File 'lib/brakeman/checks/check_without_protection.rb', line 12

def run_check
  if version_between? "0.0.0", "3.0.99"
    return
  end

  return if active_record_models.empty?

  Brakeman.debug "Finding all mass assignments"
  calls = tracker.find_call :targets => active_record_models.keys, :methods => [:new,
    :attributes=, 
    :update_attributes, 
    :update_attributes!,
    :create,
    :create!]

  Brakeman.debug "Processing all mass assignments"
  calls.each do |result|
    process_result result
  end
end