Class: Brakeman::CheckSkipBeforeFilter
- Inherits:
-
BaseCheck
- Object
- SexpProcessor
- BaseCheck
- Brakeman::CheckSkipBeforeFilter
- Defined in:
- lib/brakeman/checks/check_skip_before_filter.rb
Overview
At the moment, this looks for
skip_before_filter :verify_authenticity_token, :except => [...]
which is essentially a blacklist approach (no actions are checked EXCEPT the ones listed) versus a whitelist approach (ONLY the actions listed will skip the check)
Constant Summary
Constants inherited from BaseCheck
Constants included from Util
Util::ALL_COOKIES, Util::ALL_PARAMETERS, Util::COOKIES, Util::COOKIES_SEXP, Util::PARAMETERS, Util::PARAMS_SEXP, Util::PATH_PARAMETERS, Util::QUERY_PARAMETERS, Util::REQUEST_COOKIES, Util::REQUEST_ENV, Util::REQUEST_PARAMETERS, Util::REQUEST_PARAMS, Util::SESSION, Util::SESSION_SEXP
Constants inherited from SexpProcessor
Instance Attribute Summary
Attributes inherited from BaseCheck
Attributes inherited from SexpProcessor
Instance Method Summary collapse
- #process_skip_filter(filter, controller) ⇒ Object
- #run_check ⇒ Object
- #skip_except_value(filter) ⇒ Object
Methods inherited from BaseCheck
#add_result, inherited, #initialize, #process_call, #process_cookies, #process_default, #process_dstr, #process_if, #process_params
Methods included from Util
#array?, #block?, #call?, #camelize, #class_name, #constant?, #contains_class?, #context_for, #cookies?, #false?, #file_by_name, #file_for, #github_url, #hash?, #hash_access, #hash_insert, #hash_iterate, #integer?, #make_call, #node_type?, #number?, #params?, #pluralize, #rails_version, #regexp?, #relative_path, #request_env?, #request_value?, #result?, #set_env_defaults, #sexp?, #string?, #string_interp?, #symbol?, #table_to_csv, #template_path_to_name, #true?, #truncate_table, #underscore
Methods included from ProcessorHelper
#current_file_name, #process_all, #process_all!, #process_call_args, #process_call_defn?, #process_class, #process_module
Methods inherited from SexpProcessor
#in_context, #initialize, #process, processors, #scope
Constructor Details
This class inherits a constructor from Brakeman::BaseCheck
Instance Method Details
#process_skip_filter(filter, controller) ⇒ Object
23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 |
# File 'lib/brakeman/checks/check_skip_before_filter.rb', line 23 def process_skip_filter filter, controller case skip_except_value filter when :verify_authenticity_token warn :class => controller.name, #ugh this should be a controller warning, too :warning_type => "Cross-Site Request Forgery", :warning_code => :csrf_blacklist, :message => "Use whitelist (:only => [..]) when skipping CSRF check", :code => filter, :confidence => :medium, :file => controller.file when :login_required, :authenticate_user!, :require_user warn :controller => controller.name, :warning_code => :auth_blacklist, :warning_type => "Authentication", :message => "Use whitelist (:only => [..]) when skipping authentication", :code => filter, :confidence => :medium, :link => "authentication_whitelist", :file => controller.file end end |
#run_check ⇒ Object
15 16 17 18 19 20 21 |
# File 'lib/brakeman/checks/check_skip_before_filter.rb', line 15 def run_check tracker.controllers.each do |_name, controller| controller.skip_filters.each do |filter| process_skip_filter filter, controller end end end |
#skip_except_value(filter) ⇒ Object
46 47 48 49 50 51 52 53 54 55 56 57 58 59 |
# File 'lib/brakeman/checks/check_skip_before_filter.rb', line 46 def skip_except_value filter return false unless call? filter first_arg = filter.first_arg last_arg = filter.last_arg if symbol? first_arg and hash? last_arg if hash_access(last_arg, :except) return first_arg.value end end false end |