Class: Brakeman::CheckStripTags

Inherits:
BaseCheck show all
Defined in:
lib/brakeman/checks/check_strip_tags.rb

Overview

Check for uses of strip_tags in Rails versions before 3.0.17, 3.1.8, 3.2.8 (including 2.3.x): groups.google.com/d/topic/rubyonrails-security/FgVEtBajcTY/discussion

Check for uses of strip_tags in Rails versions before 2.3.13 and 3.0.10: groups.google.com/group/rubyonrails-security/browse_thread/thread/2b9130749b74ea12

Check for user of strip_tags with rails-html-sanitizer 1.0.2: groups.google.com/d/msg/rubyonrails-security/OU9ugTZcbjc/PjEP46pbFQAJ

Constant Summary

Constants inherited from BaseCheck

BaseCheck::CONFIDENCE

Constants included from Util

Util::ALL_COOKIES, Util::ALL_PARAMETERS, Util::COOKIES, Util::COOKIES_SEXP, Util::DIR_CONST, Util::LITERALS, Util::PARAMETERS, Util::PARAMS_SEXP, Util::PATH_PARAMETERS, Util::QUERY_PARAMETERS, Util::REQUEST_COOKIES, Util::REQUEST_ENV, Util::REQUEST_PARAMETERS, Util::REQUEST_PARAMS, Util::REQUEST_REQUEST_PARAMETERS, Util::SAFE_LITERAL, Util::SESSION, Util::SESSION_SEXP, Util::SIMPLE_LITERALS

Constants inherited from SexpProcessor

SexpProcessor::VERSION

Instance Attribute Summary

Attributes inherited from BaseCheck

#tracker, #warnings

Attributes inherited from SexpProcessor

#context, #env, #expected

Instance Method Summary collapse

Methods inherited from BaseCheck

#add_result, inherited, #initialize, #process_array, #process_call, #process_cookies, #process_default, #process_dstr, #process_if, #process_params

Methods included from Messages

#msg, #msg_code, #msg_cve, #msg_file, #msg_input, #msg_lit, #msg_plain, #msg_version

Methods included from Util

#all_literals?, #array?, #block?, #call?, #camelize, #class_name, #constant?, #contains_class?, #cookies?, #dir_glob?, #false?, #hash?, #hash_access, #hash_insert, #hash_iterate, #hash_values, #integer?, #kwsplat?, #literal?, #make_call, #node_type?, #number?, #params?, #pluralize, #rails_version, #recurse_check?, #regexp?, #remove_kwsplat, #request_env?, #request_value?, #result?, #safe_literal, #safe_literal?, #safe_literal_target?, #set_env_defaults, #sexp?, #simple_literal?, #string?, #string_interp?, #symbol?, #template_path_to_name, #true?, #underscore

Methods included from ProcessorHelper

#current_file, #process_all, #process_all!, #process_call_args, #process_call_defn?, #process_class, #process_module

Methods inherited from SexpProcessor

#in_context, #initialize, #process, processors, #scope

Constructor Details

This class inherits a constructor from Brakeman::BaseCheck

Instance Method Details

#cve_2011_2931 ⇒ Object 



25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
 
# File 'lib/brakeman/checks/check_strip_tags.rb', line 25

def cve_2011_2931
  if version_between?('2.0.0', '2.3.12') or version_between?('3.0.0', '3.0.9')
    if rails_version =~ /^3/
      message = msg("Versions before 3.0.10 have a vulnerability in ", msg_code("strip_tags"), " ", msg_cve("CVE-2011-2931"))
    else
      message = msg("Versions before 2.3.13 have a vulnerability in ", msg_code("strip_tags"), " ", msg_cve("CVE-2011-2931"))
    end

    warn :warning_type => "Cross-Site Scripting",
      :warning_code => :CVE_2011_2931,
      :message => message,
      :gem_info => gemfile_or_environment,
      :confidence => :high,
      :link_path => "https://groups.google.com/d/topic/rubyonrails-security/K5EwdJt06hI/discussion"
  end
end

#cve_2012_3465 ⇒ Object 



42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
 
# File 'lib/brakeman/checks/check_strip_tags.rb', line 42

def cve_2012_3465
  message = msg(msg_version(rails_version), " has a vulnerability in ", msg_code("strip_tags"), " ", msg_cve("CVE-2012-3465"), ". Upgrade to ")

  case
  when (version_between?('2.0.0', '2.3.14') and tracker.config.escape_html?)
    message = msg("All Rails 2.x versions have a vulnerability in ", msg_code("strip_tags"), " ", msg_cve("CVE-2012-3465"))
  when version_between?('3.0.10', '3.0.16')
    message << msg_version('3.0.17')
  when version_between?('3.1.0', '3.1.7')
    message << msg_version('3.1.8')
  when version_between?('3.2.0', '3.2.7')
    message << msg_version('3.2.8')
  else
    return
  end

  warn :warning_type => "Cross-Site Scripting",
    :warning_code => :CVE_2012_3465,
    :message => message,
    :confidence => :high,
    :gem_info => gemfile_or_environment,
    :link_path => "https://groups.google.com/d/topic/rubyonrails-security/FgVEtBajcTY/discussion"
end

#cve_2015_7579 ⇒ Object 



66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
 
# File 'lib/brakeman/checks/check_strip_tags.rb', line 66

def cve_2015_7579
  if tracker.config.gem_version(:'rails-html-sanitizer') == '1.0.2'
    if uses_strip_tags?
      confidence = :high
    else
      confidence = :medium
    end

    message = msg(msg_version("1.0.2", "rails-html-sanitizer"), " is vulnerable (CVE-2015-7579). Upgrade to ", msg_version("1.0.3", "rails-html-sanitizer"))

    warn :warning_type => "Cross-Site Scripting",
      :warning_code => :CVE_2015_7579,
      :message => message,
      :confidence => confidence,
      :gem_info => gemfile_or_environment(:"rails-html-sanitizer"),
      :link_path => "https://groups.google.com/d/msg/rubyonrails-security/OU9ugTZcbjc/PjEP46pbFQAJ"

  end
end

#run_check ⇒ Object 



16
17
18
19
20
21
22
23
 
# File 'lib/brakeman/checks/check_strip_tags.rb', line 16

def run_check
  if uses_strip_tags?
    cve_2011_2931
    cve_2012_3465
  end

  cve_2015_7579
end

#uses_strip_tags? ⇒ Boolean

Returns:

  • (Boolean) 


86
87
88
89
90
 
# File 'lib/brakeman/checks/check_strip_tags.rb', line 86

def uses_strip_tags?
  Brakeman.debug "Finding calls to strip_tags()"

  not tracker.find_call(:target => false, :method => :strip_tags, :nested => true).empty?
end