Class: RailsBestPractices::Reviews::MoveCodeIntoControllerReview

Inherits:
Review
  • Object
show all
Defined in:
lib/rails_best_practices/reviews/move_code_into_controller_review.rb

Overview

Review a view file to make sure there is no finder, finder should be moved to controller.

See the best practice details here rails-bestpractices.com/posts/24-move-code-into-controller.

Implementation:

Review process:

only check all view files to see if there are finders, then the finders should be moved to controller.

Constant Summary collapse

FINDERS = 
%w(find all first last)

Constants inherited from Core::Check

Core::Check::ALL_FILES, Core::Check::CONTROLLER_FILES, Core::Check::DEPLOY_FILES, Core::Check::HELPER_FILES, Core::Check::MAILER_FILES, Core::Check::MIGRATION_FILES, Core::Check::MODEL_FILES, Core::Check::PARTIAL_VIEW_FILES, Core::Check::ROUTE_FILES, Core::Check::SCHEMA_FILE, Core::Check::VIEW_FILES

Instance Method Summary collapse

Methods inherited from Review

#model_associations, #model_attributes, #models, #remember_variable_use_count, #reset_variable_use_count, #variable, #variable_use_count

Methods inherited from Core::Check

add_callback, #add_error, #after_prepare, #after_review, callbacks, #errors, #increment_total_files_checked!, #initialize, interesting_files, #interesting_files, #interesting_nodes, interesting_nodes, #method_missing, #node_end, #node_start, #parse_file?, #result, #total_files_checked

Constructor Details

This class inherits a constructor from RailsBestPractices::Core::Check

Dynamic Method Handling

This class handles dynamic methods through the method_missing method in the class RailsBestPractices::Core::Check

Instance Method Details

#start_assign(node) ⇒ Object

check assign nodes.

if the subject of the right value node is a constant, and the message of the right value node is one of the find, all, first and last, then it is a finder and should be moved to controller.



38
39
40
 
# File 'lib/rails_best_practices/reviews/move_code_into_controller_review.rb', line 38

def start_assign(node)
  add_error "move code into controller", node.file, node.right_value.line if finder?(node.right_value)
end

#start_method_add_arg(node) ⇒ Object

check method_add_arg nodes.

if the subject of the method_add_arg node is a constant, and the message of the method_add_arg node is one of the find, all, first and last, then it is a finder and should be moved to controller.



29
30
31
 
# File 'lib/rails_best_practices/reviews/move_code_into_controller_review.rb', line 29

def start_method_add_arg(node)
  add_error "move code into controller" if finder?(node)
end

#url ⇒ Object 



20
21
22
 
# File 'lib/rails_best_practices/reviews/move_code_into_controller_review.rb', line 20

def url
  "http://rails-bestpractices.com/posts/24-move-code-into-controller"
end