Class: RailsBestPractices::Reviews::RemoveUnusedMethodsInHelpersReview

Inherits:
Review
  • Object
show all
Includes:
Afterable, Callable, Exceptable, Moduleable
Defined in:
lib/rails_best_practices/reviews/remove_unused_methods_in_helpers_review.rb

Overview

Find out unused methods in helpers.

Implementation:

Review process:

remember all method calls in helpers.
if they are not called in views or helpers,
then they are unused methods in helpers.

Constant Summary

Constants inherited from Core::Check

Core::Check::ALL_FILES, Core::Check::CONTROLLER_FILES, Core::Check::DEPLOY_FILES, Core::Check::HELPER_FILES, Core::Check::MAILER_FILES, Core::Check::MIGRATION_FILES, Core::Check::MODEL_FILES, Core::Check::PARTIAL_VIEW_FILES, Core::Check::ROUTE_FILES, Core::Check::SCHEMA_FILE, Core::Check::VIEW_FILES

Instance Method Summary collapse

Methods inherited from Review

#model_associations, #model_attributes, #models, #remember_variable_use_count, #reset_variable_use_count, #url, #variable, #variable_use_count

Methods inherited from Core::Check

add_callback, #add_error, #after_prepare, callbacks, #errors, #increment_total_files_checked!, #interesting_files, interesting_files, interesting_nodes, #interesting_nodes, #method_missing, #node_end, #node_start, #parse_file?, #result, #total_files_checked, #url

Constructor Details

#initialize(options = {}) ⇒ RemoveUnusedMethodsInHelpersReview

Returns a new instance of RemoveUnusedMethodsInHelpersReview.



22
23
24
25
26
 
# File 'lib/rails_best_practices/reviews/remove_unused_methods_in_helpers_review.rb', line 22

def initialize(options={})
  super
  @helper_methods = Prepares.helper_methods
  self.class.interesting_files Prepares.helpers.map(&:decendants)
end

Dynamic Method Handling

This class handles dynamic methods through the method_missing method in the class RailsBestPractices::Core::Check

Instance Method Details

#after_review ⇒ Object

get all unused methods at the end of review process



29
30
31
32
33
34
35
 
# File 'lib/rails_best_practices/reviews/remove_unused_methods_in_helpers_review.rb', line 29

def after_review
  @helper_methods.get_all_unused_methods.each do |method|
    if !excepted?(method)
      add_error "remove unused methods (#{method.class_name}##{method.method_name})", method.file, method.line
    end
  end
end