Class: RailsBestPractices::Reviews::UseScopeAccessReview

Inherits:
Review show all
Defined in:
lib/rails_best_practices/reviews/use_scope_access_review.rb

Overview

Review a controller to make sure to use scope access instead of manually checking current_user and redirect.

See the best practice details here rails-bestpractices.com/posts/3-use-scope-access.

Implementation:

Review process:

check all if nodes to see

if they are compared with current_user or current_user.id,
and there is redirect_to method call in if block body,
then it should be replaced by using scope access.

Constant Summary

Constants inherited from Core::Check

Core::Check::ALL_FILES, Core::Check::CONTROLLER_FILES, Core::Check::DEPLOY_FILES, Core::Check::HELPER_FILES, Core::Check::MAILER_FILES, Core::Check::MIGRATION_FILES, Core::Check::MODEL_FILES, Core::Check::PARTIAL_VIEW_FILES, Core::Check::ROUTE_FILES, Core::Check::SCHEMA_FILE, Core::Check::VIEW_FILES

Instance Method Summary collapse

Methods inherited from Review

#model_associations, #model_attributes, #models, #remember_variable_use_count, #reset_variable_use_count, #variable, #variable_use_count

Methods inherited from Core::Check

add_callback, #add_error, #after_prepare, #after_review, callbacks, #errors, #increment_total_files_checked!, #initialize, interesting_files, #interesting_files, #interesting_nodes, interesting_nodes, #method_missing, #node_end, #node_start, #parse_file?, #result, #total_files_checked

Constructor Details

This class inherits a constructor from RailsBestPractices::Core::Check

Dynamic Method Handling

This class handles dynamic methods through the method_missing method in the class RailsBestPractices::Core::Check

Instance Method Details

#start_if(node) ⇒ Object Also known as: start_unless, start_elsif

check if node.

if it is a method call compared with current_user or current_user.id, and there is a redirect_to method call in the block body, then it should be replaced by using scope access.



31
32
33
 
# File 'lib/rails_best_practices/reviews/use_scope_access_review.rb', line 31

def start_if(node)
  add_error "use scope access" if current_user_redirect?(node)
end

#url ⇒ Object 



22
23
24
 
# File 'lib/rails_best_practices/reviews/use_scope_access_review.rb', line 22

def url
  "http://rails-bestpractices.com/posts/3-use-scope-access"
end