Class: RailsBestPractices::Reviews::MoveCodeIntoControllerReview

Inherits:
Review
  • Object
show all
Defined in:
lib/rails_best_practices/reviews/move_code_into_controller_review.rb

Overview

Review a view file to make sure there is no finder, finder should be moved to controller.

See the best practice details here rails-bestpractices.com/posts/24-move-code-into-controller.

Implementation:

Review process:

only check all view files to see if there are finders, then the finders should be moved to controller.

Constant Summary collapse

FINDERS = 
[:find, :all, :first, :last]

Constants inherited from Core::Check

Core::Check::CONTROLLER_FILES, Core::Check::HELPER_FILES, Core::Check::MAILER_FILES, Core::Check::MIGRATION_FILES, Core::Check::MODEL_FILES, Core::Check::NODE_TYPES, Core::Check::PARTIAL_VIEW_FILES, Core::Check::ROUTE_FILE, Core::Check::SCHEMA_FILE, Core::Check::VIEW_FILES

Instance Attribute Summary

Attributes inherited from Core::Check

#errors

Instance Method Summary collapse

Methods inherited from Review

#equal?, #model_associations, #model_attributes, #models, #remember_variable_use_count, #reset_variable_use_count, #variable, #variable_use_count

Methods inherited from Core::Check

#add_error, #initialize, #method_missing, #node_end, #node_start

Constructor Details

This class inherits a constructor from RailsBestPractices::Core::Check

Dynamic Method Handling

This class handles dynamic methods through the method_missing method in the class RailsBestPractices::Core::Check

Instance Method Details

#interesting_files ⇒ Object 



26
27
28
 
# File 'lib/rails_best_practices/reviews/move_code_into_controller_review.rb', line 26

def interesting_files
  VIEW_FILES
end

#interesting_nodes ⇒ Object 



22
23
24
 
# File 'lib/rails_best_practices/reviews/move_code_into_controller_review.rb', line 22

def interesting_nodes
  [:call]
end

#start_call(node) ⇒ Object

check call nodes.

if the subject of the call node is a constant, and the message of the call node is one of the :find, :all, :first and :last, then it is a finder and should be moved to controller.



35
36
37
 
# File 'lib/rails_best_practices/reviews/move_code_into_controller_review.rb', line 35

def start_call(node)
  add_error "move code into controller" if finder?(node)
end

#url ⇒ Object 



18
19
20
 
# File 'lib/rails_best_practices/reviews/move_code_into_controller_review.rb', line 18

def url
  "http://rails-bestpractices.com/posts/24-move-code-into-controller"
end