Class: RuboCop::Cop::RSpec::Rails::MinitestAssertions

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Defined in:
lib/rubocop/cop/rspec/rails/minitest_assertions.rb

Overview

Check if using Minitest matchers.

Examples:

# bad
assert_equal(a, b)
assert_equal a, b, "must be equal"
refute_equal(a, b)

# good
expect(b).to eq(a)
expect(b).to(eq(a), "must be equal")
expect(b).not_to eq(a)

Constant Summary collapse

MSG = 
'Use `%<prefer>s`.'
RESTRICT_ON_SEND = 
%i[assert_equal refute_equal].freeze

Instance Method Summary collapse

Methods inherited from Base

inherited, #on_new_investigation

Methods included from RSpec::Language::NodePattern

#block_or_numblock_pattern, #block_pattern, #numblock_pattern, #send_pattern

Methods included from RSpec::Language

#example?, #example_group?, #example_group_with_body?, #explicit_rspec?, #hook?, #include?, #let?, #rspec?, #shared_group?, #spec_group?, #subject?

Instance Method Details

#minitest_assertion(node) ⇒ Object 



27
28
29
 
# File 'lib/rubocop/cop/rspec/rails/minitest_assertions.rb', line 27

def_node_matcher :minitest_assertion, <<-PATTERN
(send nil? {:assert_equal :refute_equal} $_ $_ $_?)
PATTERN

#on_send(node) ⇒ Object 



31
32
33
34
35
36
37
38
39
 
# File 'lib/rubocop/cop/rspec/rails/minitest_assertions.rb', line 31

def on_send(node)
  minitest_assertion(node) do |expected, actual, failure_message|
    prefer = replacement(node, expected, actual,
                         failure_message.first)
    add_offense(node, message: message(prefer)) do |corrector|
      corrector.replace(node, prefer)
    end
  end
end