Module: RuboCop::Cop::MultilineExpressionIndentation

Included in:
Style::MultilineMethodCallIndentation, Style::MultilineOperationIndentation
Defined in:
lib/rubocop/cop/mixin/multiline_expression_indentation.rb

Overview

Common functionality for checking multiline method calls and binary operations.

Instance Method Summary collapse

Instance Method Details

#argument_in_method_call(node) ⇒ Object 



114
115
116
117
118
119
120
121
122
123
124
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 114

def argument_in_method_call(node)
  node.each_ancestor(:send, :block).find do |a|
    # If the node is inside a block, it makes no difference if that block
    # is an argument in a method call. It doesn't count.
    break false if a.block_type?

    _, method_name, *args = *a
    next if assignment_call?(method_name)
    args.any? { |arg| within_node?(node, arg) }
  end
end

#assignment_call?(method_name) ⇒ Boolean

Returns:

  • (Boolean) 


153
154
155
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 153

def assignment_call?(method_name)
  method_name == :[]= || method_name.to_s =~ /^\w.*=$/
end

#assignment_rhs(node) ⇒ Object 



162
163
164
165
166
167
168
169
170
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 162

def assignment_rhs(node)
  case node.type
  when :casgn   then _scope, _lhs, rhs = *node
  when :op_asgn then _lhs, _op, rhs = *node
  when :send    then _receiver, _method_name, *_args, rhs = *node
  else               _lhs, rhs = *node
  end
  rhs
end

#check(range, node, lhs, rhs) ⇒ Object 



64
65
66
67
68
69
70
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 64

def check(range, node, lhs, rhs)
  if range
    incorrect_style_detected(range, node, lhs, rhs)
  else
    correct_style_detected
  end
end

#correct_indentation(node) ⇒ Object 



54
55
56
57
58
59
60
61
62
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 54

def correct_indentation(node)
  if kw_node_with_special_indentation(node)
    # This cop could have its own IndentationWidth configuration
    configured_indentation_width +
      @config.for_cop('Style/IndentationWidth')['Width']
  else
    configured_indentation_width
  end
end

#grouped_expression?(node) ⇒ Boolean

Returns:

  • (Boolean) 


179
180
181
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 179

def grouped_expression?(node)
  node.type == :begin && node.loc.respond_to?(:begin) && node.loc.begin
end

#incorrect_style_detected(range, node, lhs, rhs) ⇒ Object 



72
73
74
75
76
77
78
79
80
81
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 72

def incorrect_style_detected(range, node, lhs, rhs)
  add_offense(range, range, message(node, lhs, rhs)) do
    if supported_styles.size > 2 ||
       offending_range(node, lhs, rhs, alternative_style)
      unrecognized_style_detected
    else
      opposite_style_detected
    end
  end
end

#indentation(node) ⇒ Object 



83
84
85
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 83

def indentation(node)
  node.source_range.source_line =~ /\S/
end

#inside_arg_list_parentheses?(node, ancestor) ⇒ Boolean

Returns:

  • (Boolean) 


183
184
185
186
187
188
189
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 183

def inside_arg_list_parentheses?(node, ancestor)
  a = ancestor.loc
  return false unless ancestor.type == :send && a.begin &&
                      a.begin.is?('(')
  n = node.source_range
  n.begin_pos > a.begin.begin_pos && n.end_pos < a.end.end_pos
end

#kw_node_with_special_indentation(node) ⇒ Object 



100
101
102
103
104
105
106
107
108
109
110
111
112
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 100

def kw_node_with_special_indentation(node)
  node.each_ancestor.find do |a|
    next unless a.loc.respond_to?(:keyword)

    case a.type
    when :if, :while, :until then expression, = *a
    when :for                then _, expression, = *a
    when :return             then expression, = *a
    end

    within_node?(node, expression) if expression
  end
end

#left_hand_side(lhs) ⇒ Object

In a chain of method calls, we regard the top send node as the base for indentation of all lines following the first. For example: a.

b c { block }.            <-- b is indented relative to a
d                         <-- d is indented relative to a



27
28
29
30
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 27

def left_hand_side(lhs)
  lhs = lhs.parent while lhs.parent && lhs.parent.send_type?
  lhs
end

#not_for_this_cop?(node) ⇒ Boolean

Returns:

  • (Boolean) 


172
173
174
175
176
177
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 172

def not_for_this_cop?(node)
  node.each_ancestor.any? do |ancestor|
    grouped_expression?(ancestor) ||
      inside_arg_list_parentheses?(node, ancestor)
  end
end

#on_send(node) ⇒ Object 



9
10
11
12
13
14
15
16
17
18
19
20
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 9

def on_send(node)
  return unless relevant_node?(node)

  receiver, method_name, *_args = *node
  return unless receiver
  return if method_name == :[] # Don't check parameters inside [].

  lhs = left_hand_side(receiver)
  rhs = right_hand_side(node)
  range = offending_range(node, lhs, rhs, style)
  check(range, node, lhs, rhs)
end

#operation_description(node, rhs) ⇒ Object 



87
88
89
90
91
92
93
94
95
96
97
98
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 87

def operation_description(node, rhs)
  ancestor = kw_node_with_special_indentation(node)
  if ancestor
    kw = ancestor.loc.keyword.source
    kind = kw == 'for' ? 'collection' : 'condition'
    article = kw =~ /^[iu]/ ? 'an' : 'a'
    "a #{kind} in #{article} `#{kw}` statement"
  else
    'an expression' +
      (part_of_assignment_rhs(node, rhs) ? ' in an assignment' : '')
  end
end

#part_of_assignment_rhs(node, candidate) ⇒ Object 



126
127
128
129
130
131
132
133
134
135
136
137
138
139
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 126

def part_of_assignment_rhs(node, candidate)
  node.each_ancestor.find do |a|
    case a.type
    when :if, :while, :until, :for, :return, :array
      break # other kinds of alignment
    when :block
      break if part_of_block_body?(candidate, a)
    when :send
      valid_method_rhs_candidate?(candidate, a)
    when *Util::ASGN_NODES
      valid_rhs_candidate?(candidate, assignment_rhs(a))
    end
  end
end

#part_of_block_body?(candidate, node) ⇒ Boolean

Returns:

  • (Boolean) 


157
158
159
160
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 157

def part_of_block_body?(candidate, node)
  _method, _args, body = *node
  body && within_node?(candidate, body)
end

#regular_method_right_hand_side(send_node) ⇒ Object 



41
42
43
44
45
46
47
48
49
50
51
52
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 41

def regular_method_right_hand_side(send_node)
  dot = send_node.loc.dot
  selector = send_node.loc.selector
  if dot && selector && dot.line == selector.line
    dot.join(selector)
  elsif selector
    selector
  elsif dot.line == send_node.loc.begin.line
    # lambda.(args)
    dot.join(send_node.loc.begin)
  end
end

#right_hand_side(send_node) ⇒ Object 



32
33
34
35
36
37
38
39
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 32

def right_hand_side(send_node)
  _, method_name, *args = *send_node
  if operator?(method_name) && args.any?
    args.first.source_range # not used for method calls
  else
    regular_method_right_hand_side(send_node)
  end
end

#valid_method_rhs_candidate?(candidate, node) ⇒ Boolean

The []= operator and setters (a.b = c) are parsed as :send nodes.

Returns:

  • (Boolean) 


142
143
144
145
146
147
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 142

def valid_method_rhs_candidate?(candidate, node)
  _receiver, method_name, *args = *node

  assignment_call?(method_name) &&
    valid_rhs_candidate?(candidate, args.last)
end

#valid_rhs_candidate?(candidate, node) ⇒ Boolean

Returns:

  • (Boolean) 


149
150
151
 
# File 'lib/rubocop/cop/mixin/multiline_expression_indentation.rb', line 149

def valid_rhs_candidate?(candidate, node)
  !candidate || within_node?(candidate, node)
end