Class: RuboCop::Cop::Performance::RedundantMerge

Inherits:
Cop
  • Object
show all
Defined in:
lib/rubocop/cop/performance/redundant_merge.rb

Overview

This cop identifies places where ‘Hash#merge!` can be replaced by `Hash#[]=`.

Examples:

hash.merge!(a: 1)
hash.merge!({'key' => 'value'})
hash.merge!(a: 1, b: 2)

Constant Summary collapse

AREF_ASGN = 
'%s[%s] = %s'.freeze
MSG = 
'Use `%s` instead of `%s`.'.freeze

Constants included from Util

Util::ASGN_NODES, Util::BYTE_ORDER_MARK, Util::EQUALS_ASGN_NODES, Util::LITERAL_REGEX, Util::OPERATOR_METHODS, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, cop_type, #correct, #debug?, #details, #display_cop_names?, #display_style_guide?, #excluded_file?, #extra_details?, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #reference_url, #relevant_file?, #style_guide_url, #target_ruby_version

Methods included from Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search_body

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, block_length, comment_line?, directions, double_quotes_acceptable?, double_quotes_required?, effective_column, ends_its_line?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, move_pos, needs_escaping?, numeric_range_size, on_node, operator?, parentheses?, parenthesized_call?, range_with_surrounding_comma, range_with_surrounding_space, source_range, strip_quotes, to_string_literal, to_symbol_literal, within_node?

Methods included from PathUtil

absolute?, match_path?, relative_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#autocorrect(node) ⇒ Object 



34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
 
# File 'lib/rubocop/cop/performance/redundant_merge.rb', line 34

def autocorrect(node)
  redundant_merge(node) do |receiver, pairs|
    lambda do |corrector|
      new_source = to_assignments(receiver, pairs).join("\n")

      parent = node.parent
      if parent && pairs.size > 1
        if modifier_flow_control(parent)
          new_source = rewrite_with_modifier(node, parent, new_source)
          node = parent
        else
          padding = "\n#{leading_spaces(node)}"
          new_source.gsub!(/\n/, padding)
        end
      end

      corrector.replace(node.source_range, new_source)
    end
  end
end

#on_send(node) ⇒ Object 



26
27
28
29
30
31
32
 
# File 'lib/rubocop/cop/performance/redundant_merge.rb', line 26

def on_send(node)
  each_redundant_merge(node) do |receiver, pairs|
    assignments = to_assignments(receiver, pairs).join('; ')
    message = format(MSG, assignments, node.source)
    add_offense(node, :expression, message)
  end
end