Class: RuboCop::Cop::Style::IfUnlessModifierOfIfUnless

Inherits:
Cop
  • Object
show all
Includes:
RuboCop::Cop::StatementModifier
Defined in:
lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb

Overview

Checks for if and unless statements used as modifers of other if or unless statements.

Examples:


# bad
tired? ? 'stop' : 'go faster' if running?

# bad
if tired?
  "please stop"
else
  "keep going"
end if running?

# good
if running?
  tired? ? 'stop' : 'go faster'
end

Constant Summary collapse

MESSAGE = 
'Avoid modifier `%s` after another conditional.'.freeze

Constants included from Util

Util::ASGN_NODES, Util::BYTE_ORDER_MARK, Util::EQUALS_ASGN_NODES, Util::LITERAL_REGEX, Util::OPERATOR_METHODS, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods included from RuboCop::Cop::StatementModifier

#body_has_comment?, #body_length, #comment_lines, #end_keyword_has_comment?, #fit_within_line_as_modifier_form?, #length, #length_in_modifier_form, #max_line_length

Methods included from IfNode

#elsif?, #if_else?, #if_node_parts, #modifier_if?, #ternary?

Methods inherited from Cop

#add_offense, all, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, cop_type, #correct, #debug?, #details, #display_cop_names?, #display_style_guide?, #excluded_file?, #extra_details?, #highlights, inherited, #initialize, #join_force?, lint?, match?, #messages, non_rails, #parse, qualified_cop_name, #reference_url, #relevant_file?, #style_guide_url, #target_ruby_version

Methods included from Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search_body

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, block_length, comment_line?, directions, double_quotes_acceptable?, double_quotes_required?, effective_column, ends_its_line?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, move_pos, needs_escaping?, numeric_range_size, on_node, operator?, parentheses?, parenthesized_call?, range_with_surrounding_comma, range_with_surrounding_space, source_range, strip_quotes, to_string_literal, to_symbol_literal, within_node?

Methods included from PathUtil

absolute?, match_path?, relative_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#message(keyword) ⇒ Object 



31
32
33
 
# File 'lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb', line 31

def message(keyword)
  format(MESSAGE, keyword)
end

#on_if(node) ⇒ Object 



35
36
37
38
39
40
41
 
# File 'lib/rubocop/cop/style/if_unless_modifier_of_if_unless.rb', line 35

def on_if(node)
  return unless modifier_if?(node)
  _cond, body, _else = if_node_parts(node)
  if body.type == :if
    add_offense(node, :keyword, message(node.loc.keyword.source))
  end
end