Class: RuboCop::Cop::Style::MutableConstant

Inherits:
Cop
  • Object
show all
Includes:
FrozenStringLiteral
Defined in:
lib/rubocop/cop/style/mutable_constant.rb

Overview

This cop checks whether some constant value isn’t a mutable literal (e.g. array or hash).

Examples:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Constant Summary collapse

MSG = 
'Freeze mutable objects assigned to constants.'.freeze

Constants included from FrozenStringLiteral

FrozenStringLiteral::FROZEN_STRING_LITERAL, FrozenStringLiteral::FROZEN_STRING_LITERAL_ENABLED, FrozenStringLiteral::FROZEN_STRING_LITERAL_TYPES

Constants included from Util

Util::ASGN_NODES, Util::BYTE_ORDER_MARK, Util::EQUALS_ASGN_NODES, Util::LITERAL_REGEX, Util::OPERATOR_METHODS, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods included from FrozenStringLiteral

frozen_string_literal_comment_exists?, frozen_string_literals_enabled?

Methods inherited from Cop

#add_offense, all, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, cop_type, #correct, #debug?, #details, #display_cop_names?, #display_style_guide?, #excluded_file?, #extra_details?, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #reference_url, #relevant_file?, #style_guide_url, #target_ruby_version

Methods included from Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search_body

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, block_length, comment_line?, directions, double_quotes_acceptable?, double_quotes_required?, effective_column, ends_its_line?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, move_pos, needs_escaping?, numeric_range_size, on_node, operator?, parentheses?, parenthesized_call?, range_with_surrounding_comma, range_with_surrounding_space, source_range, strip_quotes, to_string_literal, to_symbol_literal, within_node?

Methods included from PathUtil

absolute?, match_path?, relative_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#autocorrect(node) ⇒ Object 



31
32
33
34
35
36
37
38
39
40
41
 
# File 'lib/rubocop/cop/style/mutable_constant.rb', line 31

def autocorrect(node)
  expr = node.source_range
  lambda do |corrector|
    if node.array_type? && node.loc.begin.nil? && node.loc.end.nil?
      corrector.insert_before(expr, '[')
      corrector.insert_after(expr, '].freeze')
    else
      corrector.insert_after(expr, '.freeze')
    end
  end
end

#on_casgn(node) ⇒ Object 



21
22
23
24
 
# File 'lib/rubocop/cop/style/mutable_constant.rb', line 21

def on_casgn(node)
  _scope, _const_name, value = *node
  on_assignment(value)
end

#on_or_asgn(node) ⇒ Object 



26
27
28
29
 
# File 'lib/rubocop/cop/style/mutable_constant.rb', line 26

def on_or_asgn(node)
  lhs, value = *node
  on_assignment(value) if lhs && lhs.type == :casgn
end