Class: RuboCop::Cop::Style::HashSyntax

Inherits:
Cop
  • Object
show all
Includes:
ConfigurableEnforcedStyle
Defined in:
lib/rubocop/cop/style/hash_syntax.rb

Overview

This cop checks hash literal syntax.

It can enforce either the use of the class hash rocket syntax or the use of the newer Ruby 1.9 syntax (when applicable).

A separate offense is registered for each problematic pair.

The supported styles are:

  • ruby19 - forces use of the 1.9 syntax (e.g. 1) when hashes have all symbols for keys

  • hash_rockets - forces use of hash rockets for all hashes

  • no_mixed_keys - simply checks for hashes with mixed syntaxes

  • ruby19_no_mixed_keys - forces use of ruby 1.9 syntax and forbids mixed syntax hashes

Examples:

"EnforcedStyle => 'ruby19'"

@good
{a: 2, b: 1}
{:c => 2, 'd' => 2} # acceptable since 'd' isn't a symbol
{d: 1, 'e' => 2} # technically not forbidden

@bad
{:a => 2}
{b: 1, :c => 2}
"EnforcedStyle => 'hash_rockets'"

@good
{:a => 1, :b => 2}

@bad
{a: 1, b: 2}
{c: 1, 'd' => 5}
"EnforcedStyle => 'no_mixed_keys'"

@good
{:a => 1, :b => 2}
{c: 1, d: 2}

@bad
{:a => 1, b: 2}
{c: 1, 'd' => 2}
"EnforcedStyle => 'ruby19_no_mixed_keys'"

@good
{a: 1, b: 2}
{:c => 3, 'd' => 4}

@bad
{:a => 1, :b => 2}
{c: 2, 'd' => 3} # should just use hash rockets

Constant Summary collapse

MSG_19 = 
'Use the new Ruby 1.9 hash syntax.'.freeze
MSG_NO_MIXED_KEYS = 
"Don't mix styles in the same hash.".freeze
MSG_HASH_ROCKETS = 
'Use hash rockets syntax.'.freeze

Constants included from Util

Util::ASGN_NODES, Util::BYTE_ORDER_MARK, Util::EQUALS_ASGN_NODES, Util::LITERAL_REGEX, Util::OPERATOR_METHODS, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods included from ConfigurableEnforcedStyle

#ambiguous_style_detected, #correct_style_detected, #detected_style, #detected_style=, #no_acceptable_style!, #no_acceptable_style?, #opposite_style_detected, #parameter_name, #style, #style_detected, #supported_styles, #unexpected_style_detected

Methods inherited from Cop

#add_offense, all, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, cop_type, #correct, #debug?, #details, #display_cop_names?, #display_style_guide?, #duplicate_location?, #excluded_file?, #extra_details?, #find_location, #highlights, inherited, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #reference_url, #relevant_file?, #style_guide_url, #target_ruby_version

Methods included from Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, block_length, comment_line?, compatible_external_encoding_for?, directions, double_quotes_acceptable?, double_quotes_required?, effective_column, ends_its_line?, escape_string, first_part_of_call_chain, hard_to_type?, interpret_string_escapes, line_distance, line_range, move_pos, needs_escaping?, numeric_range_size, on_node, operator?, parentheses?, parenthesized_call?, preceed?, range_between, range_with_surrounding_comma, range_with_surrounding_space, same_line?, source_range, strip_quotes, stripped_source_upto, to_string_literal, to_symbol_literal, within_node?

Methods included from PathUtil

absolute?, match_path?, relative_path

Constructor Details

#initialize ⇒ HashSyntax

Returns a new instance of HashSyntax.



72
73
74
75
 
# File 'lib/rubocop/cop/style/hash_syntax.rb', line 72

def initialize(*)
  @force_hash_rockets = false
  super
end

Instance Method Details

#alternative_style ⇒ Object 



141
142
143
144
145
146
147
148
 
# File 'lib/rubocop/cop/style/hash_syntax.rb', line 141

def alternative_style
  case style
  when :hash_rockets then
    :ruby19
  when :ruby19, :ruby19_no_mixed_keys then
    :hash_rockets
  end
end

#autocorrect(node) ⇒ Object 



129
130
131
132
133
134
135
136
137
138
139
 
# File 'lib/rubocop/cop/style/hash_syntax.rb', line 129

def autocorrect(node)
  lambda do |corrector|
    if style == :hash_rockets || @force_hash_rockets
      autocorrect_hash_rockets(corrector, node)
    elsif style == :ruby19_no_mixed_keys || style == :no_mixed_keys
      autocorrect_no_mixed_keys(corrector, node)
    else
      autocorrect_ruby19(corrector, node)
    end
  end
end

#hash_rockets_check(node) ⇒ Object 



100
101
102
103
104
 
# File 'lib/rubocop/cop/style/hash_syntax.rb', line 100

def hash_rockets_check(node)
  pairs = *node

  check(pairs, ':', MSG_HASH_ROCKETS)
end

#no_mixed_keys_check(node) ⇒ Object 



118
119
120
121
122
123
124
125
126
127
 
# File 'lib/rubocop/cop/style/hash_syntax.rb', line 118

def no_mixed_keys_check(node)
  pairs = *node

  if !sym_indices?(pairs)
    check(pairs, ':', MSG_NO_MIXED_KEYS)
  else
    delim = pairs.first.loc.operator.source == ':' ? '=>' : ':'
    check(pairs, delim, MSG_NO_MIXED_KEYS)
  end
end

#on_hash(node) ⇒ Object 



77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
 
# File 'lib/rubocop/cop/style/hash_syntax.rb', line 77

def on_hash(node)
  if cop_config['UseHashRocketsWithSymbolValues']
    pairs = *node
    @force_hash_rockets = pairs.any? { |p| symbol_value?(p) }
  end

  if style == :hash_rockets || @force_hash_rockets
    hash_rockets_check(node)
  elsif style == :ruby19_no_mixed_keys
    ruby19_no_mixed_keys_check(node)
  elsif style == :no_mixed_keys
    no_mixed_keys_check(node)
  else
    ruby19_check(node)
  end
end

#ruby19_check(node) ⇒ Object 



94
95
96
97
98
 
# File 'lib/rubocop/cop/style/hash_syntax.rb', line 94

def ruby19_check(node)
  pairs = *node

  check(pairs, '=>', MSG_19) if sym_indices?(pairs)
end

#ruby19_no_mixed_keys_check(node) ⇒ Object 



106
107
108
109
110
111
112
113
114
115
116
 
# File 'lib/rubocop/cop/style/hash_syntax.rb', line 106

def ruby19_no_mixed_keys_check(node)
  pairs = *node

  if @force_hash_rockets
    check(pairs, ':', MSG_HASH_ROCKETS)
  elsif sym_indices?(pairs)
    check(pairs, '=>', MSG_19)
  else
    check(pairs, ':', MSG_NO_MIXED_KEYS)
  end
end