Class: RuboCop::Cop::Style::Next

Inherits:
Cop
  • Object
show all
Includes:
ConfigurableEnforcedStyle, MinBodyLength
Defined in:
lib/rubocop/cop/style/next.rb

Overview

Use ‘next` to skip iteration instead of a condition at the end.

Examples:

# bad
[1, 2].each do |a|
  if a == 1 do
    puts a
  end
end

# good
[1, 2].each do |a|
  next unless a == 1
  puts a
end

Constant Summary collapse

MSG = 
'Use `next` to skip iteration.'.freeze
EXIT_TYPES = 
[:break, :return].freeze
EACH_ = 
'each_'.freeze
ENUMERATORS = 
[:collect, :collect_concat, :detect, :downto, :each,
:find, :find_all, :find_index, :inject, :loop, :map!,
:map, :reduce, :reject, :reject!, :reverse_each, :select,
:select!, :times, :upto].freeze

Constants included from Util

Util::ASGN_NODES, Util::BYTE_ORDER_MARK, Util::CONDITIONAL_NODES, Util::EQUALS_ASGN_NODES, Util::LITERAL_REGEX, Util::LOGICAL_OPERATOR_NODES, Util::MODIFIER_NODES, Util::OPERATOR_METHODS, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods included from MinBodyLength

#min_body_length, #min_body_length?

Methods included from ConfigurableEnforcedStyle

#alternative_style, #alternative_styles, #ambiguous_style_detected, #correct_style_detected, #detected_style, #detected_style=, #no_acceptable_style!, #no_acceptable_style?, #opposite_style_detected, #style, #style_detected, #style_parameter_name, #supported_styles, #unexpected_style_detected

Methods inherited from Cop

#add_offense, all, badge, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, #correct, department, #duplicate_location?, #excluded_file?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #relevant_file?, #target_ruby_version

Methods included from AST::Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, block_length, comment_line?, compatible_external_encoding_for?, directions, double_quotes_acceptable?, double_quotes_required?, effective_column, ends_its_line?, escape_string, first_part_of_call_chain, hard_to_type?, interpret_string_escapes, line_distance, line_range, move_pos, needs_escaping?, numeric_range_size, on_node, operator?, parentheses?, parenthesized_call?, preceed?, range_between, range_with_surrounding_comma, range_with_surrounding_space, same_line?, source_range, strip_quotes, stripped_source_upto, to_string_literal, to_supported_styles, to_symbol_literal, within_node?

Methods included from PathUtil

absolute?, match_path?, relative_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#investigate(_processed_source) ⇒ Object 



33
34
35
36
37
 
# File 'lib/rubocop/cop/style/next.rb', line 33

def investigate(_processed_source)
  # When correcting nested offenses, we need to keep track of how much
  # we have adjusted the indentation of each line
  @reindented_lines = Hash.new(0)
end

#on_block(node) ⇒ Object 



39
40
41
42
43
44
45
46
47
48
49
 
# File 'lib/rubocop/cop/style/next.rb', line 39

def on_block(node)
  block_owner, _, body = *node
  return unless block_owner.send_type?
  return unless body && ends_with_condition?(body)

  _, method_name = *block_owner
  return unless enumerator?(method_name)

  offense_node = offense_node(body)
  add_offense(offense_node, offense_location(offense_node), MSG)
end

#on_while(node) ⇒ Object Also known as: on_until, on_for 



51
52
53
54
55
56
57
 
# File 'lib/rubocop/cop/style/next.rb', line 51

def on_while(node)
  return unless node.body && ends_with_condition?(node.body)

  offending_node = offense_node(node.body)

  add_offense(offending_node, offense_location(offending_node), MSG)
end