Class: RuboCop::Cop::Lint::UriRegexp

Inherits:
Cop
  • Object
show all
Defined in:
lib/rubocop/cop/lint/uri_regexp.rb

Overview

This cop identifies places where ‘URI.regexp` is obsolete and should not be used. Instead, use `URI::DEFAULT_PARSER.make_regexp`.

Examples:

# bad
URI.regexp('http://example.com')

# good
URI::DEFAULT_PARSER.make_regexp('http://example.com')

Constant Summary collapse

MSG = 
'`%<top_level>sURI.regexp%<arg>s` is obsolete and should not ' \
'be used. Instead, use `%<top_level>sURI::DEFAULT_PARSER.' \
'make_regexp%<arg>s`.'.freeze

Constants included from Util

Util::ASGN_NODES, Util::BYTE_ORDER_MARK, Util::CONDITIONAL_NODES, Util::EQUALS_ASGN_NODES, Util::LITERAL_REGEX, Util::LOGICAL_OPERATOR_NODES, Util::MODIFIER_NODES, Util::OPERATOR_METHODS, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, autocorrect_incompatible_with, badge, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, #correct, department, #duplicate_location?, #excluded_file?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #relevant_file?, #target_rails_version, #target_ruby_version

Methods included from AST::Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, comment_line?, double_quotes_required?, effective_column, ends_its_line?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, needs_escaping?, on_node, operator?, parentheses?, parenthesized_call?, precede?, range_between, range_by_whole_lines, range_with_surrounding_comma, range_with_surrounding_space, same_line?, source_range, strip_quotes, stripped_source_upto, symbol_without_quote?, to_string_literal, to_supported_styles, to_symbol_literal, within_node?

Methods included from PathUtil

absolute?, find_file_upwards, match_path?, pwd, relative_path, reset_pwd, smart_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#autocorrect(node) ⇒ Object 



44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
 
# File 'lib/rubocop/cop/lint/uri_regexp.rb', line 44

def autocorrect(node)
  lambda do |corrector|
    if (captured_values = uri_regexp_with_argument?(node))
    else
      captured_values = uri_regexp_without_argument?(node)
    end

    double_colon, arg = captured_values

    top_level = double_colon ? '::' : ''
    argument = arg ? "('#{arg}')" : ''

    corrector.replace(
      node.loc.expression,
      "#{top_level}URI::DEFAULT_PARSER.make_regexp#{argument}"
    )
  end
end

#on_send(node) ⇒ Object 



32
33
34
35
36
37
38
39
40
41
42
 
# File 'lib/rubocop/cop/lint/uri_regexp.rb', line 32

def on_send(node)
  uri_regexp_with_argument?(node) do |double_colon, arg|
    register_offense(
      node, top_level: double_colon ? '::' : '', arg: "('#{arg}')"
    )
  end

  uri_regexp_without_argument?(node) do |double_colon|
    register_offense(node, top_level: double_colon ? '::' : '')
  end
end