Class: RuboCop::Cop::Rails::ActiveSupportAliases

Inherits:
Cop
  • Object
show all
Defined in:
lib/rubocop/cop/rails/active_support_aliases.rb

Overview

This cop checks that ActiveSupport aliases to core ruby methods are not used.

Examples:

# good
'some_string'.start_with?('prefix')
'some_string'.end_with?('suffix')
[1, 2, 'a'] << 'b'
[1, 2, 'a'].unshift('b')

# bad
'some_string'.starts_with?('prefix')
'some_string'.ends_with?('suffix')
[1, 2, 'a'].append('b')
[1, 2, 'a'].prepend('b')

Constant Summary collapse

MSG = 
'Use `%<prefer>s` instead of `%<current>s`.'.freeze
ALIASES = 
{
  starts_with?: {
    original: :start_with?, matcher: '(send str :starts_with? _)'
  },
  ends_with?: {
    original: :end_with?, matcher: '(send str :ends_with? _)'
  },
  append: { original: :<<, matcher: '(send array :append _)' },
  prepend: { original: :unshift, matcher: '(send array :prepend _)' }
}.freeze

Constants included from Util

Util::ASGN_NODES, Util::BYTE_ORDER_MARK, Util::CONDITIONAL_NODES, Util::EQUALS_ASGN_NODES, Util::LITERAL_REGEX, Util::LOGICAL_OPERATOR_NODES, Util::MODIFIER_NODES, Util::OPERATOR_METHODS, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, autocorrect_incompatible_with, badge, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, #correct, department, #duplicate_location?, #excluded_file?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #relevant_file?, #target_rails_version, #target_ruby_version

Methods included from AST::Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, comment_line?, double_quotes_required?, effective_column, ends_its_line?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, needs_escaping?, on_node, operator?, parentheses?, parenthesized_call?, precede?, range_between, range_by_whole_lines, range_with_surrounding_comma, range_with_surrounding_space, same_line?, source_range, strip_quotes, stripped_source_upto, symbol_without_quote?, to_string_literal, to_supported_styles, to_symbol_literal, within_node?

Methods included from PathUtil

absolute?, find_file_upwards, match_path?, pwd, relative_path, reset_pwd, smart_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#autocorrect(node) ⇒ Object 



47
48
49
50
51
52
53
54
 
# File 'lib/rubocop/cop/rails/active_support_aliases.rb', line 47

def autocorrect(node)
  return false if append(node)
  lambda do |corrector|
    method_name = node.loc.selector.source
    replacement = ALIASES[method_name.to_sym][:original]
    corrector.replace(node.loc.selector, replacement.to_s)
  end
end

#on_send(node) ⇒ Object 



40
41
42
43
44
45
 
# File 'lib/rubocop/cop/rails/active_support_aliases.rb', line 40

def on_send(node)
  ALIASES.each_key do |aliased_method|
    register_offense(node, aliased_method) if
      public_send(aliased_method, node)
  end
end