Class: RuboCop::Cop::InternalAffairs::NodeDestructuring

Inherits:
Cop
  • Object
show all
Defined in:
lib/rubocop/cop/internal_affairs/node_destructuring.rb

Overview

Checks that node destructuring is done either using the node extensions or using a splat.

Examples:

Using splat expansion


# bad
receiver, method_name, arguments = send_node.children

# good
receiver, method_name, arguments = *send_node

Using node extensions


# bad
_receiver, method_name, _arguments = send_node.children

# good
method_name = send_node.method_name

Constant Summary collapse

MSG =
'Use the methods provided with the node extensions, or ' \
'destructure the node using `*`.'.freeze

Constants included from Util

Util::ASGN_NODES, Util::CONDITIONAL_NODES, Util::EQUALS_ASGN_NODES, Util::LITERAL_REGEX, Util::LOGICAL_OPERATOR_NODES, Util::MODIFIER_NODES, Util::OPERATOR_METHODS, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, autocorrect_incompatible_with, badge, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, #correct, department, #duplicate_location?, #excluded_file?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #relevant_file?, #target_rails_version, #target_ruby_version

Methods included from AST::Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from RuboCop::Cop::IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, comment_line?, double_quotes_required?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, needs_escaping?, on_node, operator?, parentheses?, same_line?, to_string_literal, to_supported_styles, tokens

Methods included from PathUtil

absolute?, match_path?, pwd, relative_path, reset_pwd, smart_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#on_masgn(node) ⇒ Object



32
33
34
35
36
# File 'lib/rubocop/cop/internal_affairs/node_destructuring.rb', line 32

def on_masgn(node)
  node_children_destructuring?(node) do
    add_offense(node)
  end
end