Class: RuboCop::Cop::Lint::DuplicateCaseCondition

Inherits:
Cop
  • Object
show all
Defined in:
lib/rubocop/cop/lint/duplicate_case_condition.rb

Overview

This cop checks that there are no repeated conditions used in case ‘when’ expressions.

Examples:


# bad

case x
when 'first'
  do_something
when 'first'
  do_something_else
end

# good

case x
when 'first'
  do_something
when 'second'
  do_something_else
end

Constant Summary collapse

MSG = 
'Duplicate `when` condition detected.'.freeze

Constants included from Util

Util::ASGN_NODES, Util::CONDITIONAL_NODES, Util::EQUALS_ASGN_NODES, Util::LITERAL_REGEX, Util::LOGICAL_OPERATOR_NODES, Util::MODIFIER_NODES, Util::OPERATOR_METHODS, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, autocorrect_incompatible_with, badge, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, #correct, department, #duplicate_location?, #excluded_file?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #relevant_file?, #target_rails_version, #target_ruby_version

Methods included from AST::Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, comment_line?, double_quotes_required?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, needs_escaping?, on_node, operator?, parentheses?, same_line?, to_string_literal, to_supported_styles, tokens

Methods included from PathUtil

absolute?, match_path?, pwd, relative_path, reset_pwd, smart_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#on_case(case_node) ⇒ Object 



33
34
35
36
37
38
39
40
41
42
43
 
# File 'lib/rubocop/cop/lint/duplicate_case_condition.rb', line 33

def on_case(case_node)
  case_node.when_branches.each_with_object([]) do |when_node, previous|
    when_node.each_condition do |condition|
      next unless repeated_condition?(previous, condition)

      add_offense(condition)
    end

    previous.push(when_node.conditions)
  end
end