Class: RuboCop::Cop::Lint::NextWithoutAccumulator

Inherits:
Cop
  • Object
show all
Defined in:
lib/rubocop/cop/lint/next_without_accumulator.rb

Overview

Don’t omit the accumulator when calling ‘next` in a `reduce` block.

Examples:


# bad

result = (1..4).reduce(0) do |acc, i|
  next if i.odd?
  acc + i
end

# good

result = (1..4).reduce(0) do |acc, i|
  next acc if i.odd?
  acc + i
end

Constant Summary collapse

MSG = 
'Use `next` with an accumulator argument in a `reduce`.'.freeze

Constants included from Util

Util::ASGN_NODES, Util::CONDITIONAL_NODES, Util::EQUALS_ASGN_NODES, Util::LITERAL_REGEX, Util::LOGICAL_OPERATOR_NODES, Util::MODIFIER_NODES, Util::OPERATOR_METHODS, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, autocorrect_incompatible_with, badge, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, #correct, department, #duplicate_location?, #excluded_file?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #relevant_file?, #target_rails_version, #target_ruby_version

Methods included from AST::Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, comment_line?, double_quotes_required?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, needs_escaping?, on_node, operator?, parentheses?, same_line?, to_string_literal, to_supported_styles, tokens

Methods included from PathUtil

absolute?, match_path?, pwd, relative_path, reset_pwd, smart_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#on_block(node) ⇒ Object 



32
33
34
35
36
37
38
39
40
 
# File 'lib/rubocop/cop/lint/next_without_accumulator.rb', line 32

def on_block(node)
  on_body_of_reduce(node) do |body|
    void_next = body.each_node(:next).find do |n|
      n.children.empty? && parent_block_node(n) == node
    end

    add_offense(void_next) if void_next
  end
end