Class: RuboCop::Cop::Performance::EndWith

Inherits:
Cop
  • Object
show all
Defined in:
lib/rubocop/cop/performance/end_with.rb

Overview

This cop identifies unnecessary use of a regex where ‘String#end_with?` would suffice.

Examples:

# bad
'abc'.match?(/bc\Z/)
'abc' =~ /bc\Z/
'abc'.match(/bc\Z/)

# good
'abc'.end_with?('bc')

Constant Summary collapse

MSG = 
'Use `String#end_with?` instead of a regex match anchored to ' \
'the end of the string.'.freeze
SINGLE_QUOTE = 
"'".freeze

Constants included from Util

Util::ASGN_NODES, Util::CONDITIONAL_NODES, Util::EQUALS_ASGN_NODES, Util::LITERAL_REGEX, Util::LOGICAL_OPERATOR_NODES, Util::MODIFIER_NODES, Util::OPERATOR_METHODS, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, autocorrect_incompatible_with, badge, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, #correct, department, #duplicate_location?, #excluded_file?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #relevant_file?, #target_rails_version, #target_ruby_version

Methods included from AST::Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, comment_line?, double_quotes_required?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, needs_escaping?, on_node, operator?, parentheses?, same_line?, to_string_literal, to_supported_styles, tokens

Methods included from PathUtil

absolute?, match_path?, pwd, relative_path, reset_pwd, smart_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#autocorrect(node) ⇒ Object 



40
41
42
43
44
45
46
47
48
49
50
51
52
 
# File 'lib/rubocop/cop/performance/end_with.rb', line 40

def autocorrect(node)
  redundant_regex?(node) do |receiver, regex_str|
    receiver, regex_str = regex_str, receiver if receiver.is_a?(String)
    regex_str = regex_str[0..-3] # drop \Z anchor
    regex_str = interpret_string_escapes(regex_str)

    lambda do |corrector|
      new_source = receiver.source + '.end_with?(' +
                   to_string_literal(regex_str) + ')'
      corrector.replace(node.source_range, new_source)
    end
  end
end

#literal_at_end?(regex_str) ⇒ Boolean

Returns:

  • (Boolean) 


27
28
29
30
31
32
 
# File 'lib/rubocop/cop/performance/end_with.rb', line 27

def literal_at_end?(regex_str)
  # is this regexp 'literal' in the sense of only matching literal
  # chars, rather than using metachars like . and * and so on?
  # also, is it anchored at the end of the string?
  regex_str =~ /\A(?:#{LITERAL_REGEX})+\\z\z/
end

#on_send(node) ⇒ Object 



34
35
36
37
38
 
# File 'lib/rubocop/cop/performance/end_with.rb', line 34

def on_send(node)
  return unless redundant_regex?(node)

  add_offense(node)
end