Class: RuboCop::Cop::Performance::RedundantSortBy

Inherits:
Cop
  • Object
show all
Includes:
RangeHelp
Defined in:
lib/rubocop/cop/performance/redundant_sort_by.rb

Overview

This cop identifies places where ‘sort_by { … }` can be replaced by `sort`.

Examples:

# bad
array.sort_by { |x| x }
array.sort_by do |var|
  var
end

# good
array.sort

Constant Summary collapse

MSG = 
'Use `sort` instead of `sort_by { |%<var>s| %<var>s }`.'.freeze

Constants included from Util

Util::ASGN_NODES, Util::CONDITIONAL_NODES, Util::EQUALS_ASGN_NODES, Util::LITERAL_REGEX, Util::LOGICAL_OPERATOR_NODES, Util::MODIFIER_NODES, Util::OPERATOR_METHODS, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, autocorrect_incompatible_with, badge, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, #correct, department, #duplicate_location?, #excluded_file?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #relevant_file?, #target_rails_version, #target_ruby_version

Methods included from AST::Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, comment_line?, double_quotes_required?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, needs_escaping?, on_node, operator?, parentheses?, same_line?, to_string_literal, to_supported_styles, tokens

Methods included from PathUtil

absolute?, match_path?, pwd, relative_path, reset_pwd, smart_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#autocorrect(node) ⇒ Object 



37
38
39
40
 
# File 'lib/rubocop/cop/performance/redundant_sort_by.rb', line 37

def autocorrect(node)
  send, = *node
  ->(corrector) { corrector.replace(sort_by_range(send, node), 'sort') }
end

#on_block(node) ⇒ Object 



27
28
29
30
31
32
33
34
35
 
# File 'lib/rubocop/cop/performance/redundant_sort_by.rb', line 27

def on_block(node)
  redundant_sort_by(node) do |send, var_name|
    range = sort_by_range(send, node)

    add_offense(node,
                location: range,
                message: format(MSG, var: var_name))
  end
end