Class: RuboCop::Cop::Style::EmptyElse

Inherits:
Cop
  • Object
show all
Includes:
ConfigurableEnforcedStyle, OnNormalIfUnless, RangeHelp
Defined in:
lib/rubocop/cop/style/empty_else.rb

Overview

Checks for empty else-clauses, possibly including comments and/or an explicit ‘nil` depending on the EnforcedStyle.

Examples:

EnforcedStyle: empty

# warn only on empty else

# bad
if condition
  statement
else
end

# good
if condition
  statement
else
  nil
end

# good
if condition
  statement
else
  statement
end

# good
if condition
  statement
end

EnforcedStyle: nil

# warn on else with nil in it

# bad
if condition
  statement
else
  nil
end

# good
if condition
  statement
else
end

# good
if condition
  statement
else
  statement
end

# good
if condition
  statement
end

EnforcedStyle: both (default)

# warn on empty else and else with nil in it

# bad
if condition
  statement
else
  nil
end

# bad
if condition
  statement
else
end

# good
if condition
  statement
else
  statement
end

# good
if condition
  statement
end

Constant Summary collapse

MSG = 
'Redundant `else`-clause.'.freeze

Constants included from Util

Util::ASGN_NODES, Util::CONDITIONAL_NODES, Util::EQUALS_ASGN_NODES, Util::LITERAL_REGEX, Util::LOGICAL_OPERATOR_NODES, Util::MODIFIER_NODES, Util::OPERATOR_METHODS, Util::SHORTHAND_ASGN_NODES

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods included from ConfigurableEnforcedStyle

#alternative_style, #alternative_styles, #ambiguous_style_detected, #correct_style_detected, #detected_style, #detected_style=, #no_acceptable_style!, #no_acceptable_style?, #opposite_style_detected, #style, #style_detected, #style_parameter_name, #supported_styles, #unexpected_style_detected

Methods included from OnNormalIfUnless

#on_if

Methods inherited from Cop

#add_offense, all, autocorrect_incompatible_with, badge, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, #correct, department, #duplicate_location?, #excluded_file?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #relevant_file?, #target_rails_version, #target_ruby_version

Methods included from AST::Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, comment_line?, double_quotes_required?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, needs_escaping?, on_node, operator?, parentheses?, same_line?, to_string_literal, to_supported_styles, tokens

Methods included from PathUtil

absolute?, match_path?, pwd, relative_path, reset_pwd, smart_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#autocorrect(node) ⇒ Object 



107
108
109
110
111
112
113
114
115
 
# File 'lib/rubocop/cop/style/empty_else.rb', line 107

def autocorrect(node)
  return false if autocorrect_forbidden?(node.type.to_s)
  return false if comment_in_else?(node)

  lambda do |corrector|
    end_pos = base_node(node).loc.end.begin_pos
    corrector.remove(range_between(node.loc.else.begin_pos, end_pos))
  end
end

#on_case(node) ⇒ Object 



103
104
105
 
# File 'lib/rubocop/cop/style/empty_else.rb', line 103

def on_case(node)
  check(node)
end

#on_normal_if_unless(node) ⇒ Object 



99
100
101
 
# File 'lib/rubocop/cop/style/empty_else.rb', line 99

def on_normal_if_unless(node)
  check(node)
end