Class: RuboCop::Cop::Style::OneLineConditional

Inherits:
Cop
  • Object
show all
Includes:
OnNormalIfUnless
Defined in:
lib/rubocop/cop/style/one_line_conditional.rb

Overview

TODO: Make configurable. Checks for uses of if/then/else/end on a single line.

Examples:

# bad
if foo then boo else doo end
unless foo then boo else goo end

# good
foo ? boo : doo
boo if foo
if foo then boo end

# good
if foo
  boo
else
  doo
end

Constant Summary collapse

MSG = 
'Favor the ternary operator (`?:`) ' \
'over `%<keyword>s/then/else/end` constructs.'.freeze

Constants included from Util

Util::LITERAL_REGEX

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods included from OnNormalIfUnless

#on_if

Methods inherited from Cop

#add_offense, all, autocorrect_incompatible_with, badge, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, #correct, department, #duplicate_location?, #excluded_file?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #messages, non_rails, #parse, qualified_cop_name, #relevant_file?, #target_rails_version, #target_ruby_version

Methods included from AST::Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, comment_line?, double_quotes_required?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, needs_escaping?, on_node, parentheses?, same_line?, to_string_literal, to_supported_styles, tokens

Methods included from PathUtil

absolute?, hidden_dir?, hidden_file_in_not_hidden_dir?, match_path?, pwd, relative_path, reset_pwd, smart_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#autocorrect(node) ⇒ Object 



37
38
39
40
41
 
# File 'lib/rubocop/cop/style/one_line_conditional.rb', line 37

def autocorrect(node)
  lambda do |corrector|
    corrector.replace(node.source_range, replacement(node))
  end
end

#on_normal_if_unless(node) ⇒ Object 



31
32
33
34
35
 
# File 'lib/rubocop/cop/style/one_line_conditional.rb', line 31

def on_normal_if_unless(node)
  return unless node.single_line? && node.else_branch

  add_offense(node)
end