Class: RuboCop::Cop::Lint::RescueException

Inherits:
Cop
  • Object
show all
Defined in:
lib/rubocop/cop/lint/rescue_exception.rb

Overview

This cop checks for rescue blocks targeting the Exception class.

Examples:


# bad

begin
  do_something
rescue Exception
  handle_exception
end

# good

begin
  do_something
rescue ArgumentError
  handle_exception
end

Constant Summary collapse

MSG = 
'Avoid rescuing the `Exception` class. ' \
'Perhaps you meant to rescue `StandardError`?'.freeze

Constants included from Util

Util::LITERAL_REGEX

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, autocorrect_incompatible_with, badge, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, #correct, department, #duplicate_location?, #excluded_file?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #relevant_file?, #target_rails_version, #target_ruby_version

Methods included from AST::Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, comment_line?, double_quotes_required?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, needs_escaping?, on_node, parentheses?, same_line?, to_string_literal, to_supported_styles, tokens, trim_string_interporation_escape_character

Methods included from PathUtil

absolute?, chdir, hidden_dir?, hidden_file_in_not_hidden_dir?, match_path?, pwd, relative_path, reset_pwd, smart_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#on_resbody(node) ⇒ Object 



31
32
33
34
35
36
37
38
 
# File 'lib/rubocop/cop/lint/rescue_exception.rb', line 31

def on_resbody(node)
  return unless node.children.first

  rescue_args = node.children.first.children
  return unless rescue_args.any? { |a| targets_exception?(a) }

  add_offense(node)
end

#targets_exception?(rescue_arg_node) ⇒ Boolean

Returns:

  • (Boolean) 


40
41
42
 
# File 'lib/rubocop/cop/lint/rescue_exception.rb', line 40

def targets_exception?(rescue_arg_node)
  rescue_arg_node.const_name == 'Exception'
end