Class: RuboCop::Cop::Performance::Size

Inherits:
Cop
  • Object
show all
Defined in:
lib/rubocop/cop/performance/size.rb

Overview

This cop is used to identify usages of ‘count` on an `Array` and `Hash` and change them to `size`.

TODO: Add advanced detection of variables that could have been assigned to an array or a hash.

Examples:

# bad
[1, 2, 3].count

# bad
{a: 1, b: 2, c: 3}.count

# good
[1, 2, 3].size

# good
{a: 1, b: 2, c: 3}.size

# good
[1, 2, 3].count { |e| e > 2 }

Constant Summary collapse

MSG = 
'Use `size` instead of `count`.'.freeze

Constants included from Util

Util::LITERAL_REGEX

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, autocorrect_incompatible_with, badge, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, #correct, department, #duplicate_location?, #excluded_file?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #relevant_file?, #target_rails_version, #target_ruby_version

Methods included from AST::Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, comment_line?, double_quotes_required?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, needs_escaping?, on_node, parentheses?, same_line?, to_string_literal, to_supported_styles, tokens, trim_string_interporation_escape_character

Methods included from PathUtil

absolute?, chdir, hidden_dir?, hidden_file_in_not_hidden_dir?, match_path?, pwd, relative_path, reset_pwd, smart_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#autocorrect(node) ⇒ Object 



35
36
37
 
# File 'lib/rubocop/cop/performance/size.rb', line 35

def autocorrect(node)
  ->(corrector) { corrector.replace(node.loc.selector, 'size') }
end

#on_send(node) ⇒ Object 



29
30
31
32
33
 
# File 'lib/rubocop/cop/performance/size.rb', line 29

def on_send(node)
  return unless eligible_node?(node)

  add_offense(node, location: :selector)
end