Class: RuboCop::Cop::Rails::Present

Inherits:
Cop
  • Object
show all
Defined in:
lib/rubocop/cop/rails/present.rb

Overview

This cop checks for code that can be written with simpler conditionals using ‘Object#present?` defined by Active Support.

Interaction with ‘Style/UnlessElse`: The configuration of `NotBlank` will not produce an offense in the context of `unless else` if `Style/UnlessElse` is inabled. This is to prevent interference between the auto-correction of the two cops.

Examples:

NotNilAndNotEmpty: true (default)

# Converts usages of `!nil? && !empty?` to `present?`

# bad
!foo.nil? && !foo.empty?

# bad
foo != nil && !foo.empty?

# good
foo.present?

NotBlank: true (default)

# Converts usages of `!blank?` to `present?`

# bad
!foo.blank?

# bad
not foo.blank?

# good
foo.present?

UnlessBlank: true (default)

# Converts usages of `unless blank?` to `if present?`

# bad
something unless foo.blank?

# good
something if foo.present?

Constant Summary collapse

MSG_NOT_BLANK = 
'Use `%<prefer>s` instead of `%<current>s`.'
MSG_EXISTS_AND_NOT_EMPTY = 
'Use `%<prefer>s` instead of ' \
'`%<current>s`.'
MSG_UNLESS_BLANK = 
'Use `if %<prefer>s` instead of ' \
'`%<current>s`.'

Constants included from Util

Util::LITERAL_REGEX

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, autocorrect_incompatible_with, badge, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, #correct, department, #duplicate_location?, #excluded_file?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #relevant_file?, #target_rails_version, #target_ruby_version

Methods included from AST::Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, comment_line?, double_quotes_required?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, needs_escaping?, on_node, parentheses?, same_line?, to_string_literal, to_supported_styles, tokens, trim_string_interporation_escape_character

Methods included from PathUtil

absolute?, chdir, hidden_dir?, hidden_file_in_not_hidden_dir?, match_path?, pwd, relative_path, reset_pwd, smart_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#autocorrect(node) ⇒ Object 



120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
 
# File 'lib/rubocop/cop/rails/present.rb', line 120

def autocorrect(node)
  lambda do |corrector|
    method_call, variable1 = unless_blank?(node)

    if method_call
      corrector.replace(node.loc.keyword, 'if')
      range = method_call.loc.expression
    else
      variable1, _variable2 =
        exists_and_not_empty?(node) || not_blank?(node)
      range = node.loc.expression
    end

    corrector.replace(range, replacement(variable1))
  end
end

#on_and(node) ⇒ Object 



84
85
86
87
88
89
90
91
92
93
94
95
 
# File 'lib/rubocop/cop/rails/present.rb', line 84

def on_and(node)
  return unless cop_config['NotNilAndNotEmpty']

  exists_and_not_empty?(node) do |var1, var2|
    return unless var1 == var2

    add_offense(node,
                message: format(MSG_EXISTS_AND_NOT_EMPTY,
                                prefer: replacement(var1),
                                current: node.source))
  end
end

#on_if(node) ⇒ Object 



107
108
109
110
111
112
113
114
115
116
117
118
 
# File 'lib/rubocop/cop/rails/present.rb', line 107

def on_if(node)
  return unless cop_config['UnlessBlank']
  return unless node.unless?
  return if node.else? && config.for_cop('Style/UnlessElse')['Enabled']

  unless_blank?(node) do |method_call, receiver|
    range = unless_condition(node, method_call)
    msg = format(MSG_UNLESS_BLANK, prefer: replacement(receiver),
                                   current: range.source)
    add_offense(node, location: range, message: msg)
  end
end

#on_or(node) ⇒ Object 



97
98
99
100
101
102
103
104
105
 
# File 'lib/rubocop/cop/rails/present.rb', line 97

def on_or(node)
  return unless cop_config['NilOrEmpty']

  exists_and_not_empty?(node) do |var1, var2|
    return unless var1 == var2

    add_offense(node, message: MSG_EXISTS_AND_NOT_EMPTY)
  end
end

#on_send(node) ⇒ Object 



73
74
75
76
77
78
79
80
81
82
 
# File 'lib/rubocop/cop/rails/present.rb', line 73

def on_send(node)
  return unless cop_config['NotBlank']

  not_blank?(node) do |receiver|
    add_offense(node,
                message: format(MSG_NOT_BLANK,
                                prefer: replacement(receiver),
                                current: node.source))
  end
end