Class: RuboCop::Cop::Security::JSONLoad

Inherits:
Cop
  • Object
show all
Defined in:
lib/rubocop/cop/security/json_load.rb

Overview

This cop checks for the use of JSON class methods which have potential security issues.

Autocorrect is disabled by default because it’s potentially dangerous. If using a stream, like ‘JSON.load(open(’file’))‘, it will need to call `#read` manually, like `JSON.parse(open(’file’).read)‘. If reading single values (rather than proper JSON objects), like `JSON.load(’false’)‘, it will need to pass the `quirks_mode: true` option, like `JSON.parse(’false’, quirks_mode: true)‘. Other similar issues may apply.

Examples:

# bad
JSON.load("{}")
JSON.restore("{}")

# good
JSON.parse("{}")

Constant Summary collapse

MSG = 
'Prefer `JSON.parse` over `JSON.%<method>s`.'

Constants included from Util

Util::LITERAL_REGEX

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, autocorrect_incompatible_with, badge, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, cop_name, #cop_name, #correct, department, #duplicate_location?, #excluded_file?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #message, #messages, non_rails, #parse, qualified_cop_name, #relevant_file?, #target_rails_version, #target_ruby_version

Methods included from AST::Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, comment_line?, double_quotes_required?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, needs_escaping?, on_node, parentheses?, same_line?, to_string_literal, to_supported_styles, tokens, trim_string_interporation_escape_character

Methods included from PathUtil

absolute?, chdir, hidden_dir?, hidden_file_in_not_hidden_dir?, match_path?, pwd, relative_path, reset_pwd, smart_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#autocorrect(node) ⇒ Object 



40
41
42
 
# File 'lib/rubocop/cop/security/json_load.rb', line 40

def autocorrect(node)
  ->(corrector) { corrector.replace(node.loc.selector, 'parse') }
end

#on_send(node) ⇒ Object 



32
33
34
35
36
37
38
 
# File 'lib/rubocop/cop/security/json_load.rb', line 32

def on_send(node)
  json_load(node) do |method|
    add_offense(node,
                location: :selector,
                message: format(MSG, method: method))
  end
end