Class: RuboCop::Cop::Style::UnneededCondition

Inherits:
Cop
  • Object
show all
Includes:
RangeHelp
Defined in:
lib/rubocop/cop/style/unneeded_condition.rb

Overview

This cop checks for unnecessary conditional expressions.

Examples:

# bad
a = b ? b : c

# good
a = b || c
# bad
if b
  b
else
  c
end

# good
b || c

# good
if b
  b
elsif cond
  c
end

Constant Summary collapse

MSG = 
'Use double pipes `||` instead.'
UNNEEDED_CONDITION = 
'This condition is not needed.'

Constants included from Util

Util::LITERAL_REGEX

Instance Attribute Summary

Attributes inherited from Cop

#config, #corrections, #offenses, #processed_source

Instance Method Summary collapse

Methods inherited from Cop

#add_offense, all, autocorrect_incompatible_with, badge, #config_to_allow_offenses, #config_to_allow_offenses=, #cop_config, #cop_name, cop_name, #correct, department, #disable_uncorrectable, #duplicate_location?, #excluded_file?, #find_location, #highlights, inherited, #initialize, #join_force?, lint?, match?, #messages, #parse, qualified_cop_name, #reason_to_not_correct, #relevant_file?, #target_rails_version, #target_ruby_version

Methods included from AST::Sexp

#s

Methods included from NodePattern::Macros

#def_node_matcher, #def_node_search, #node_search, #node_search_all, #node_search_body, #node_search_first

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #correctable?, #disable_offense, #disable_uncorrectable?, #support_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

begins_its_line?, comment_line?, double_quotes_required?, escape_string, first_part_of_call_chain, interpret_string_escapes, line_range, needs_escaping?, on_node, parentheses?, same_line?, to_string_literal, to_supported_styles, tokens, trim_string_interporation_escape_character

Methods included from PathUtil

absolute?, chdir, hidden_dir?, hidden_file_in_not_hidden_dir?, match_path?, pwd, relative_path, reset_pwd, smart_path

Constructor Details

This class inherits a constructor from RuboCop::Cop::Cop

Instance Method Details

#autocorrect(node) ⇒ Object 



46
47
48
49
50
51
52
53
54
55
56
57
58
 
# File 'lib/rubocop/cop/style/unneeded_condition.rb', line 46

def autocorrect(node)
  lambda do |corrector|
    if node.ternary?
      corrector.replace(range_of_offense(node), '||')
    elsif node.modifier_form? || !node.else_branch
      corrector.replace(node.source_range, node.if_branch.source)
    else
      corrected = make_ternary_form(node)

      corrector.replace(node.source_range, corrected)
    end
  end
end

#on_if(node) ⇒ Object 



39
40
41
42
43
44
 
# File 'lib/rubocop/cop/style/unneeded_condition.rb', line 39

def on_if(node)
  return if node.elsif_conditional?
  return unless offense?(node)

  add_offense(node, location: range_of_offense(node))
end