Class: RuboCop::Cop::InternalAffairs::RedundantMethodDispatchNode

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Includes:
RangeHelp
Defined in:
lib/rubocop/cop/internal_affairs/redundant_method_dispatch_node.rb

Overview

Checks for redundant ‘send_node` method dispatch node.

Examples:


# bad
node.send_node.method_name

# good
node.method_name

# bad
node.send_node.method?(:method_name)

# good
node.method?(:method_name)

# bad
node.send_node.receiver

# good
node.receiver

Constant Summary collapse

MSG =
'Remove the redundant `send_node`.'
RESTRICT_ON_SEND =
%i[method_name method? receiver].freeze

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Methods inherited from Base

#active_support_extensions_enabled?, #add_global_offense, #add_offense, #always_autocorrect?, autocorrect_incompatible_with, badge, #begin_investigation, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #cop_config, cop_name, #cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, #inspect, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #parser_engine, #ready, #relevant_file?, requires_gem, #string_literals_frozen_by_default?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from RuboCop::Cop::IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#dispatch_method(node) ⇒ Object



36
37
38
39
40
41
# File 'lib/rubocop/cop/internal_affairs/redundant_method_dispatch_node.rb', line 36

def_node_matcher :dispatch_method, <<~PATTERN
  {
    (send $(send _ :send_node) {:method_name :receiver})
    (send $(send _ :send_node) :method? _)
  }
PATTERN

#on_send(node) ⇒ Object



43
44
45
46
47
48
49
50
51
52
# File 'lib/rubocop/cop/internal_affairs/redundant_method_dispatch_node.rb', line 43

def on_send(node)
  return unless (dispatch_node = dispatch_method(node))
  return unless (dot = dispatch_node.loc.dot)

  range = range_between(dot.begin_pos, dispatch_node.loc.selector.end_pos)

  add_offense(range) do |corrector|
    corrector.remove(range)
  end
end