Class: RuboCop::Cop::Layout::RedundantLineBreak

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Includes:
CheckAssignment, CheckSingleLineSuitability
Defined in:
lib/rubocop/cop/layout/redundant_line_break.rb

Overview

Checks whether certain expressions, e.g. method calls, that could fit completely on a single line, are broken up into multiple lines unnecessarily.

Examples:

any configuration

# bad
foo(
  a,
  b
)

puts 'string that fits on ' \
     'a single line'

things
  .select { |thing| thing.cond? }
  .join('-')

# good
foo(a, b)

puts 'string that fits on a single line'

things.select { |thing| thing.cond? }.join('-')

InspectBlocks: false (default)

# good
foo(a) do |x|
  puts x
end

InspectBlocks: true

# bad
foo(a) do |x|
  puts x
end

# good
foo(a) { |x| puts x }

Constant Summary collapse

MSG =
'Redundant line break detected.'

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Methods included from CheckSingleLineSuitability

#suitable_as_single_line?

Methods included from CheckAssignment

extract_rhs

Methods inherited from Base

#active_support_extensions_enabled?, #add_global_offense, #add_offense, #always_autocorrect?, autocorrect_incompatible_with, badge, #begin_investigation, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #cop_config, cop_name, #cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, #inspect, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #parser_engine, #ready, #relevant_file?, requires_gem, #string_literals_frozen_by_default?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_lvasgn(node) ⇒ Object



52
53
54
# File 'lib/rubocop/cop/layout/redundant_line_break.rb', line 52

def on_lvasgn(node)
  super unless end_with_percent_blank_string?(processed_source)
end

#on_send(node) ⇒ Object Also known as: on_csend



56
57
58
59
60
61
62
63
64
65
# File 'lib/rubocop/cop/layout/redundant_line_break.rb', line 56

def on_send(node)
  # Include "the whole expression".
  node = node.parent while node.parent&.send_type? ||
                           convertible_block?(node) ||
                           node.parent.is_a?(RuboCop::AST::BinaryOperatorNode)

  return unless offense?(node) && !part_of_ignored_node?(node)

  register_offense(node)
end