Class: RuboCop::Cop::Lint::DuplicateSetElement

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Defined in:
lib/rubocop/cop/lint/duplicate_set_element.rb

Overview

Checks for duplicate literal, constant, or variable elements in Set.

Examples:


# bad
Set[:foo, :bar, :foo]

# good
Set[:foo, :bar]

# bad
Set.new([:foo, :bar, :foo])

# good
Set.new([:foo, :bar])

# bad
[:foo, :bar, :foo].to_set

# good
[:foo, :bar].to_set

Constant Summary collapse

MSG =
'Remove the duplicate element in Set.'
RESTRICT_ON_SEND =
%i[\[\] new to_set].freeze

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Methods inherited from Base

#active_support_extensions_enabled?, #add_global_offense, #add_offense, #always_autocorrect?, autocorrect_incompatible_with, badge, #begin_investigation, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #cop_config, cop_name, #cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, #inspect, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #parser_engine, #ready, #relevant_file?, requires_gem, #string_literals_frozen_by_default?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_send(node) ⇒ Object Also known as: on_csend



43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
# File 'lib/rubocop/cop/lint/duplicate_set_element.rb', line 43

def on_send(node)
  return unless (set_elements = set_init_elements(node))

  seen_elements = Set[]

  set_elements.each_with_index do |set_element, index|
    # NOTE: Skip due to the possibility of corner cases where Set elements
    # may have changing return values if they are not literals, constants, or variables.
    next if !set_element.literal? && !set_element.const_type? && !set_element.variable?

    if seen_elements.include?(set_element)
      register_offense(set_element, set_elements[index - 1])
    else
      seen_elements << set_element
    end
  end
end

#set_init_elements(node) ⇒ Object



35
36
37
38
39
40
41
# File 'lib/rubocop/cop/lint/duplicate_set_element.rb', line 35

def_node_matcher :set_init_elements, <<~PATTERN
  {
    (send (const {nil? cbase} :Set) :[] $...)
    (send (const {nil? cbase} :Set) :new (array $...))
    (call (array $...) :to_set)
  }
PATTERN