Class: RuboCop::Cop::Lint::ImplicitStringConcatenation

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Defined in:
lib/rubocop/cop/lint/implicit_string_concatenation.rb

Overview

Checks for implicit string concatenation of string literals which are on the same line.

Examples:


# bad
array = ['Item 1' 'Item 2']

# good
array = ['Item 1Item 2']
array = ['Item 1' + 'Item 2']
array = [
  'Item 1' \
  'Item 2'
]

Constant Summary collapse

MSG = 
'Combine %<lhs>s and %<rhs>s into a single string ' \
'literal, rather than using implicit string concatenation.'
FOR_ARRAY = 
' Or, if they were intended to be separate array ' \
'elements, separate them with a comma.'
FOR_METHOD = 
' Or, if they were intended to be separate method ' \
'arguments, separate them with a comma.'

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Methods inherited from Base

#active_support_extensions_enabled?, #add_global_offense, #add_offense, #always_autocorrect?, autocorrect_incompatible_with, badge, #begin_investigation, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #cop_config, cop_name, #cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, #inspect, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #parser_engine, #ready, #relevant_file?, requires_gem, #string_literals_frozen_by_default?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_dstr(node) ⇒ Object

rubocop:disable Metrics/AbcSize, Metrics/MethodLength, Metrics/PerceivedComplexity



32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
 
# File 'lib/rubocop/cop/lint/implicit_string_concatenation.rb', line 32

def on_dstr(node)
  each_bad_cons(node) do |lhs_node, rhs_node|
    range = lhs_node.source_range.join(rhs_node.source_range)
    message = format(MSG, lhs: display_str(lhs_node), rhs: display_str(rhs_node))
    if node.parent&.array_type?
      message << FOR_ARRAY
    elsif node.parent&.send_type?
      message << FOR_METHOD
    end

    add_offense(range, message: message) do |corrector|
      if lhs_node.value == ''
        corrector.remove(lhs_node)
      elsif rhs_node.value == ''
        corrector.remove(rhs_node)
      else
        range = lhs_node.source_range.end.join(rhs_node.source_range.begin)

        corrector.replace(range, ' + ')
      end
    end
  end
end