Class: RuboCop::Cop::Security::MarshalLoad

Inherits:
Base
  • Object
show all
Defined in:
lib/rubocop/cop/security/marshal_load.rb

Overview

Checks for the use of Marshal class methods which have potential security issues leading to remote code execution when loading from an untrusted source.

Examples:

# bad
Marshal.load("{}")
Marshal.restore("{}")

# good
Marshal.dump("{}")

# okish - deep copy hack
Marshal.load(Marshal.dump({}))

Constant Summary collapse

MSG = 
'Avoid using `Marshal.%<method>s`.'
RESTRICT_ON_SEND = 
%i[load restore].freeze

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods inherited from Base

#active_support_extensions_enabled?, #add_global_offense, #add_offense, #always_autocorrect?, autocorrect_incompatible_with, badge, #begin_investigation, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #cop_config, cop_name, #cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, #inspect, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #parser_engine, #ready, #relevant_file?, requires_gem, #string_literals_frozen_by_default?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#marshal_load(node) ⇒ Object 



26
27
28
29
 
# File 'lib/rubocop/cop/security/marshal_load.rb', line 26

def_node_matcher :marshal_load, <<~PATTERN
  (send (const {nil? cbase} :Marshal) ${:load :restore}
  !(send (const {nil? cbase} :Marshal) :dump ...))
PATTERN

#on_send(node) ⇒ Object 



31
32
33
34
35
 
# File 'lib/rubocop/cop/security/marshal_load.rb', line 31

def on_send(node)
  marshal_load(node) do |method|
    add_offense(node.loc.selector, message: format(MSG, method: method))
  end
end