Class: RuboCop::Cop::Style::EachWithObject

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Includes:
RangeHelp
Defined in:
lib/rubocop/cop/style/each_with_object.rb

Overview

Looks for inject / reduce calls where the passed in object is returned at the end and so could be replaced by each_with_object without the need to return the object at the end.

However, we can’t replace with each_with_object if the accumulator parameter is assigned to within the block.

Examples:

# bad
[1, 2].inject({}) { |a, e| a[e] = e; a }

# good
[1, 2].each_with_object({}) { |e, a| a[e] = e }

Constant Summary collapse

MSG = 
'Use `each_with_object` instead of `%<method>s`.'
METHODS = 
%i[inject reduce].freeze

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Methods inherited from Base

#active_support_extensions_enabled?, #add_global_offense, #add_offense, #always_autocorrect?, autocorrect_incompatible_with, badge, #begin_investigation, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #cop_config, cop_name, #cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, #inspect, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #parser_engine, #ready, #relevant_file?, requires_gem, #string_literals_frozen_by_default?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_block(node) ⇒ Object 



26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
 
# File 'lib/rubocop/cop/style/each_with_object.rb', line 26

def on_block(node)
  each_with_object_block_candidate?(node) do |method, args, body|
    _, method_name, method_arg = *method
    return if simple_method_arg?(method_arg)

    return_value = return_value(body)
    return unless return_value
    return unless first_argument_returned?(args, return_value)
    return if accumulator_param_assigned_to?(body, args)

    message = format(MSG, method: method_name)
    add_offense(method.loc.selector, message: message) do |corrector|
      autocorrect_block(corrector, node, return_value)
    end
  end
end

#on_numblock(node) ⇒ Object 



43
44
45
46
47
48
49
50
51
52
53
54
55
 
# File 'lib/rubocop/cop/style/each_with_object.rb', line 43

def on_numblock(node)
  each_with_object_numblock_candidate?(node) do |method, body|
    _, method_name, method_arg = *method
    return if simple_method_arg?(method_arg)

    return unless return_value(body)&.source == '_1'

    message = format(MSG, method: method_name)
    add_offense(method.loc.selector, message: message) do |corrector|
      autocorrect_numblock(corrector, node)
    end
  end
end