Class: RuboCop::Cop::Style::RedundantArrayConstructor

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Defined in:
lib/rubocop/cop/style/redundant_array_constructor.rb

Overview

Checks for the instantiation of array using redundant ‘Array` constructor. Autocorrect replaces to array literal which is the simplest and fastest.

Examples:


# bad
Array.new([])
Array[]
Array([])
Array.new(['foo', 'foo', 'foo'])
Array['foo', 'foo', 'foo']
Array(['foo', 'foo', 'foo'])

# good
[]
['foo', 'foo', 'foo']
Array.new(3, 'foo')
Array.new(3) { 'foo' }

Constant Summary collapse

MSG = 
'Remove the redundant `Array` constructor.'
RESTRICT_ON_SEND = 
%i[new [] Array].freeze

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Methods inherited from Base

#active_support_extensions_enabled?, #add_global_offense, #add_offense, #always_autocorrect?, autocorrect_incompatible_with, badge, #begin_investigation, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #cop_config, cop_name, #cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, #inspect, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #parser_engine, #ready, #relevant_file?, requires_gem, #string_literals_frozen_by_default?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_send(node) ⇒ Object 



47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
 
# File 'lib/rubocop/cop/style/redundant_array_constructor.rb', line 47

def on_send(node)
  return unless (array_literal = redundant_array_constructor(node))

  receiver = node.receiver
  selector = node.loc.selector

  if node.method?(:new)
    range = receiver.source_range.join(selector)
    replacement = array_literal
  elsif node.method?(:Array)
    range = selector
    replacement = array_literal
  else
    range = receiver
    replacement = selector.begin.join(node.source_range.end)
  end

  register_offense(range, node, replacement)
end

#redundant_array_constructor(node) ⇒ Object 



33
34
35
36
37
38
39
40
41
42
43
44
45
 
# File 'lib/rubocop/cop/style/redundant_array_constructor.rb', line 33

def_node_matcher :redundant_array_constructor, <<~PATTERN
  {
    (send
      (const {nil? cbase} :Array) :new
      $(array ...))
    (send
      (const {nil? cbase} :Array) :[]
      $...)
    (send
      nil? :Array
      $(array ...))
  }
PATTERN