Class: RuboCop::Cop::Style::RedundantCondition

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Includes:
RangeHelp
Defined in:
lib/rubocop/cop/style/redundant_condition.rb

Overview

Checks for unnecessary conditional expressions.

Examples:

# bad
a = b ? b : c

# good
a = b || c

# bad
if b
  b
else
  c
end

# good
b || c

# good
if b
  b
elsif cond
  c
end

Constant Summary collapse

MSG = 
'Use double pipes `||` instead.'
REDUNDANT_CONDITION = 
'This condition is not needed.'
ARGUMENT_WITH_OPERATOR_TYPES = 
%i[
  splat block_pass forwarded_restarg forwarded_kwrestarg forwarded_args
].freeze

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Methods inherited from Base

#active_support_extensions_enabled?, #add_global_offense, #add_offense, #always_autocorrect?, autocorrect_incompatible_with, badge, #begin_investigation, callbacks_needed, #callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #cop_config, cop_name, #cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, #inspect, joining_forces, lint?, match?, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #parser_engine, #ready, #relevant_file?, requires_gem, #string_literals_frozen_by_default?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_if(node) ⇒ Object

rubocop:disable Metrics/AbcSize



43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
 
# File 'lib/rubocop/cop/style/redundant_condition.rb', line 43

def on_if(node)
  return if node.modifier_form? || node.elsif_conditional? || !offense?(node)

  message = message(node)

  add_offense(range_of_offense(node), message: message) do |corrector|
    if node.ternary? && !branches_have_method?(node)
      correct_ternary(corrector, node)
    elsif redundant_condition?(node)
      corrector.replace(node, node.if_branch.source)
    else
      corrected = make_ternary_form(node)

      corrector.replace(node, corrected)
    end
  end
end