Class: RuboCop::Cop::Style::RedundantDoubleSplatHashBraces

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Defined in:
lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb

Overview

Checks for redundant uses of double splat hash braces.

Examples:


# bad
do_something(**{foo: bar, baz: qux})

# good
do_something(foo: bar, baz: qux)

# bad
do_something(**{foo: bar, baz: qux}.merge(options))

# good
do_something(foo: bar, baz: qux, **options)

Constant Summary collapse

MSG = 
'Remove the redundant double splat and braces, use keyword arguments directly.'
MERGE_METHODS = 
%i[merge merge!].freeze

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Methods inherited from Base

#active_support_extensions_enabled?, #add_global_offense, #add_offense, #always_autocorrect?, autocorrect_incompatible_with, badge, #begin_investigation, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #cop_config, cop_name, #cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, #inspect, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #parser_engine, #ready, #relevant_file?, requires_gem, #string_literals_frozen_by_default?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_hash(node) ⇒ Object

rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity



29
30
31
32
33
34
35
36
37
38
39
40
 
# File 'lib/rubocop/cop/style/redundant_double_splat_hash_braces.rb', line 29

def on_hash(node)
  return if node.pairs.empty? || node.pairs.any?(&:hash_rocket?)
  return unless (parent = node.parent)
  return unless parent.call_type? || parent.kwsplat_type?
  return unless mergeable?(parent)
  return unless (kwsplat = node.each_ancestor(:kwsplat).first)
  return if !node.braces? || allowed_double_splat_receiver?(kwsplat)

  add_offense(kwsplat) do |corrector|
    autocorrect(corrector, node, kwsplat)
  end
end