Class: RuboCop::Cop::Style::RedundantMinMaxBy

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Includes:
RangeHelp
Defined in:
lib/rubocop/cop/style/redundant_min_max_by.rb

Overview

Identifies places where ‘max_by { … }`, `min_by { … }`, or `minmax_by { … }` can be replaced by max, min, or minmax.

Examples:

# bad
array.max_by { |x| x }
array.min_by { |x| x }
array.minmax_by { |x| x }

# good
array.max
array.min
array.minmax

Constant Summary collapse

MSG_BLOCK = 
'Use `%<replacement>s` instead of `%<original>s { |%<var>s| %<var>s }`.'
MSG_NUMBLOCK = 
'Use `%<replacement>s` instead of `%<original>s { _1 }`.'
MSG_ITBLOCK = 
'Use `%<replacement>s` instead of `%<original>s { it }`.'
REPLACEMENTS = 
{ max_by: 'max', min_by: 'min', minmax_by: 'minmax' }.freeze

Constants included from RangeHelp

RangeHelp::BYTE_ORDER_MARK, RangeHelp::NOT_GIVEN

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Methods inherited from Base

#active_support_extensions_enabled?, #add_global_offense, #add_offense, #always_autocorrect?, autocorrect_incompatible_with, badge, #begin_investigation, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #cop_config, #cop_name, cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, #inspect, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #parser_engine, #ready, #relevant_file?, requires_gem, #string_literals_frozen_by_default?, support_autocorrect?, support_multiple_source?, #target_gem_version, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_block(node) ⇒ Object 



29
30
31
32
33
 
# File 'lib/rubocop/cop/style/redundant_min_max_by.rb', line 29

def on_block(node)
  redundant_minmax_by_block(node) do |send, var_name|
    register_offense(send, node, message_block(send, var_name))
  end
end

#on_itblock(node) ⇒ Object 



41
42
43
44
45
 
# File 'lib/rubocop/cop/style/redundant_min_max_by.rb', line 41

def on_itblock(node)
  redundant_minmax_by_itblock(node) do |send|
    register_offense(send, node, message_itblock(send))
  end
end

#on_numblock(node) ⇒ Object 



35
36
37
38
39
 
# File 'lib/rubocop/cop/style/redundant_min_max_by.rb', line 35

def on_numblock(node)
  redundant_minmax_by_numblock(node) do |send|
    register_offense(send, node, message_numblock(send))
  end
end