Class: RuboCop::Cop::Style::StringHashKeys

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Defined in:
lib/rubocop/cop/style/string_hash_keys.rb

Overview

Checks for the use of strings as keys in hashes. The use of symbols is preferred instead.

Examples:

# bad
{ 'one' => 1, 'two' => 2, 'three' => 3 }

# good
{ one: 1, two: 2, three: 3 }

Constant Summary collapse

MSG = 
'Prefer symbols instead of strings as hash keys.'

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Methods inherited from Base

#active_support_extensions_enabled?, #add_global_offense, #add_offense, #always_autocorrect?, autocorrect_incompatible_with, badge, #begin_investigation, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #cop_config, cop_name, #cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, #inspect, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #parser_engine, #ready, #relevant_file?, requires_gem, #string_literals_frozen_by_default?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Instance Method Details

#on_pair(node) ⇒ Object 



42
43
44
45
46
47
48
49
50
51
52
53
54
 
# File 'lib/rubocop/cop/style/string_hash_keys.rb', line 42

def on_pair(node)
  return unless string_hash_key?(node)

  key_content = node.key.str_content
  return unless key_content.valid_encoding?
  return if receive_environments_method?(node)

  add_offense(node.key) do |corrector|
    symbol_content = key_content.to_sym.inspect

    corrector.replace(node.key, symbol_content)
  end
end

#receive_environments_method?(node) ⇒ Object 



30
31
32
33
34
35
36
37
38
39
40
 
# File 'lib/rubocop/cop/style/string_hash_keys.rb', line 30

def_node_matcher :receive_environments_method?, <<~PATTERN
  {
    ^^(send (const {nil? cbase} :IO) :popen ...)
    ^^(send (const {nil? cbase} :Open3)
        {:capture2 :capture2e :capture3 :popen2 :popen2e :popen3} ...)
    ^^^(send (const {nil? cbase} :Open3)
        {:pipeline :pipeline_r :pipeline_rw :pipeline_start :pipeline_w} ...)
    ^^(send {nil? (const {nil? cbase} :Kernel)} {:spawn :system} ...)
    ^^(send _ {:gsub :gsub!} ...)
  }
PATTERN

#string_hash_key?(node) ⇒ Object 



25
26
27
 
# File 'lib/rubocop/cop/style/string_hash_keys.rb', line 25

def_node_matcher :string_hash_key?, <<~PATTERN
  (pair (str _) _)
PATTERN