Class: RuboCop::Cop::Style::SymbolProc

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Includes:
AllowedMethods, AllowedPattern, CommentsHelp, RangeHelp
Defined in:
lib/rubocop/cop/style/symbol_proc.rb

Overview

Use symbols as procs when possible.

If you prefer a style that allows block for method with arguments, please set ‘true` to `AllowMethodsWithArguments`. `define_method?` methods are allowed by default. These are customizable with `AllowedMethods` option.

Examples:

# bad
something.map { |s| s.upcase }
something.map { _1.upcase }

# good
something.map(&:upcase)

AllowMethodsWithArguments: false (default)

# bad
something.do_something(foo) { |o| o.bar }

# good
something.do_something(foo, &:bar)

AllowMethodsWithArguments: true

# good
something.do_something(foo) { |o| o.bar }

AllowComments: false (default)

# bad
something.do_something do |s| # some comment
  # some comment
  s.upcase # some comment
  # some comment
end

AllowComments: true

# good  - if there are comment in either position
something.do_something do |s| # some comment
  # some comment
  s.upcase # some comment
  # some comment
end

AllowedMethods: [define_method] (default)

# good
define_method(:foo) { |foo| foo.bar }

AllowedPatterns: [] (default)

# bad
something.map { |s| s.upcase }

AllowedPatterns: [‘map’] (default)

# good
something.map { |s| s.upcase }

AllCops:ActiveSupportExtensionsEnabled: false (default)

# bad
->(x) { x.foo }
proc { |x| x.foo }
Proc.new { |x| x.foo }

# good
lambda(&:foo)
proc(&:foo)
Proc.new(&:foo)

AllCops:ActiveSupportExtensionsEnabled: true

# good
->(x) { x.foo }
proc { |x| x.foo }
Proc.new { |x| x.foo }

Constant Summary collapse

MSG = 
'Pass `&:%<method>s` as an argument to `%<block_method>s` instead of a block.'
SUPER_TYPES = 
%i[super zsuper].freeze
LAMBDA_OR_PROC = 
%i[lambda proc].freeze

Constants inherited from Base

Base::RESTRICT_ON_SEND

Instance Attribute Summary

Attributes inherited from Base

#config, #processed_source

Class Method Summary collapse

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Methods included from CommentsHelp

#comments_contain_disables?, #comments_in_range, #contains_comments?, #source_range_with_comment

Methods inherited from Base

#active_support_extensions_enabled?, #add_global_offense, #add_offense, #always_autocorrect?, badge, #begin_investigation, #callbacks_needed, callbacks_needed, #config_to_allow_offenses, #config_to_allow_offenses=, #contextual_autocorrect?, #cop_config, cop_name, #cop_name, department, documentation_url, exclude_from_registry, #excluded_file?, #external_dependency_checksum, inherited, #initialize, #inspect, joining_forces, lint?, match?, #message, #offenses, #on_investigation_end, #on_new_investigation, #on_other_file, #parse, #parser_engine, #ready, #relevant_file?, requires_gem, #string_literals_frozen_by_default?, support_autocorrect?, support_multiple_source?, #target_rails_version, #target_ruby_version

Methods included from ExcludeLimit

#exclude_limit

Methods included from AutocorrectLogic

#autocorrect?, #autocorrect_enabled?, #autocorrect_requested?, #autocorrect_with_disable_uncorrectable?, #correctable?, #disable_uncorrectable?, #safe_autocorrect?

Methods included from IgnoredNode

#ignore_node, #ignored_node?, #part_of_ignored_node?

Methods included from Util

silence_warnings

Constructor Details

This class inherits a constructor from RuboCop::Cop::Base

Class Method Details

.autocorrect_incompatible_with ⇒ Object 



165
166
167
 
# File 'lib/rubocop/cop/style/symbol_proc.rb', line 165

def self.autocorrect_incompatible_with
  [Layout::SpaceBeforeBlockBraces]
end

Instance Method Details

#destructuring_block_argument?(argument_node) ⇒ Boolean

Returns:

  • (Boolean) 


189
190
191
 
# File 'lib/rubocop/cop/style/symbol_proc.rb', line 189

def destructuring_block_argument?(argument_node)
  argument_node.one? && argument_node.source.include?(',')
end

#on_block(node) ⇒ Object Also known as: on_numblock

rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity



170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
 
# File 'lib/rubocop/cop/style/symbol_proc.rb', line 170

def on_block(node)
  symbol_proc?(node) do |dispatch_node, arguments_node, method_name|
    if active_support_extensions_enabled?
      return if proc_node?(dispatch_node)
      return if LAMBDA_OR_PROC.include?(dispatch_node.method_name)
    end
    return if unsafe_hash_usage?(dispatch_node)
    return if unsafe_array_usage?(dispatch_node)
    return if allowed_method_name?(dispatch_node.method_name)
    return if allow_if_method_has_argument?(node.send_node)
    return if node.block_type? && destructuring_block_argument?(arguments_node)
    return if allow_comments? && contains_comments?(node)

    register_offense(node, method_name, dispatch_node.method_name)
  end
end

#proc_node?(node) ⇒ Object 



152
 
# File 'lib/rubocop/cop/style/symbol_proc.rb', line 152

def_node_matcher :proc_node?, '(send (const {nil? cbase} :Proc) :new)'

#symbol_proc?(node) ⇒ Object 



158
159
160
161
162
163
 
# File 'lib/rubocop/cop/style/symbol_proc.rb', line 158

def_node_matcher :symbol_proc?, <<~PATTERN
  {
    (block $#symbol_proc_receiver? $(args (arg _var)) (send (lvar _var) $_))
    (numblock $#symbol_proc_receiver? $1 (send (lvar :_1) $_))
  }
PATTERN

#symbol_proc_receiver?(node) ⇒ Object 



155
 
# File 'lib/rubocop/cop/style/symbol_proc.rb', line 155

def_node_matcher :symbol_proc_receiver?, '{(call ...) (super ...) zsuper}'