Class: RuboCop::Cop::Style::UnlessElse

Inherits:
Base
  • Object
show all
Extended by:
AutoCorrector
Includes:
RangeHelp
Defined in:
lib/rubocop/cop/style/unless_else.rb

Overview

Looks for ‘unless` expressions with `else` clauses.

Examples:

# bad
unless foo_bar.nil?
  # do something...
else
  # do a different thing...
end

# good
if foo_bar.present?
  # do something...
else
  # do a different thing...
end

Constant Summary collapse

MSG = 
'Do not use `unless` with `else`. Rewrite these with the positive case first.'

Instance Method Summary collapse

Methods included from AutoCorrector

support_autocorrect?

Instance Method Details

#on_if(node) ⇒ Object 



28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
 
# File 'lib/rubocop/cop/style/unless_else.rb', line 28

def on_if(node)
  return unless node.unless? && node.else?

  add_offense(node) do |corrector|
    body_range = range_between_condition_and_else(node, node.condition)
    else_range = range_between_else_and_end(node)

    next if part_of_ignored_node?(node)

    corrector.replace(node.loc.keyword, 'if')
    corrector.replace(body_range, else_range.source)
    corrector.replace(else_range, body_range.source)
  end

  ignore_node(node)
end

#range_between_condition_and_else(node, condition) ⇒ Object 



45
46
47
 
# File 'lib/rubocop/cop/style/unless_else.rb', line 45

def range_between_condition_and_else(node, condition)
  range_between(condition.source_range.end_pos, node.loc.else.begin_pos)
end

#range_between_else_and_end(node) ⇒ Object 



49
50
51
 
# File 'lib/rubocop/cop/style/unless_else.rb', line 49

def range_between_else_and_end(node)
  range_between(node.loc.else.end_pos, node.loc.end.begin_pos)
end