Class: Simplabs::Excellent::Checks::ForLoopCheck

Inherits:
Base
  • Object
show all
Defined in:
lib/simplabs/excellent/checks/for_loop_check.rb

Overview

This check reports code that uses for loops as in:

for user in @users
  do_something(user)
end

The use of for loops in Ruby is contrary to the language’s basic concept of iterators. The above statement would better be written as:

@users.each do |user|
  do_something(user)
end

Applies to

  • for loops

Instance Attribute Summary

Attributes inherited from Base

#interesting_files, #interesting_nodes, #warnings

Instance Method Summary collapse

Methods inherited from Base

#add_warning, #evaluate_node, #warnings_for

Constructor Details

#initialize ⇒ ForLoopCheck

:nodoc:


26
27
28
29
30
 
# File 'lib/simplabs/excellent/checks/for_loop_check.rb', line 26

def initialize #:nodoc:
  super
  @interesting_nodes = [:for]
  @interesting_files = [/\.rb$/, /\.erb$/]
end

Instance Method Details

#evaluate(context) ⇒ Object

:nodoc:


32
33
34
 
# File 'lib/simplabs/excellent/checks/for_loop_check.rb', line 32

def evaluate(context) #:nodoc:
  add_warning(context, 'For loop used.')
end